From 1c82d856623253a8dbaa5d3a7ef507cf7849dada Mon Sep 17 00:00:00 2001
From: Miodec <bartnikjack@gmail.com>
Date: Mon, 5 Sep 2022 15:16:50 +0200
Subject: [PATCH] not sending awards if maxXpReward is 0

---
 .../src/jobs/announce-daily-leaderboards.ts   | 46 ++++++++++---------
 1 file changed, 24 insertions(+), 22 deletions(-)

diff --git a/backend/src/jobs/announce-daily-leaderboards.ts b/backend/src/jobs/announce-daily-leaderboards.ts
index f1e827ef4..239ccc457 100644
--- a/backend/src/jobs/announce-daily-leaderboards.ts
+++ b/backend/src/jobs/announce-daily-leaderboards.ts
@@ -54,32 +54,34 @@ async function announceDailyLeaderboard(
   if (inboxConfig.enabled) {
     const { maxXpReward, minXpReward, maxResults } = dailyLeaderboardsConfig;
 
-    const mailEntries = allResults.map((entry) => {
-      const rank = entry.rank ?? maxResults;
+    if (maxXpReward > 0) {
+      const mailEntries = allResults.map((entry) => {
+        const rank = entry.rank ?? maxResults;
 
-      const placementString = getOrdinalNumberString(rank);
-      const xpReward = Math.floor(
-        mapRange(rank, 1, maxResults, maxXpReward, minXpReward)
-      );
+        const placementString = getOrdinalNumberString(rank);
+        const xpReward = Math.floor(
+          mapRange(rank, 1, maxResults, maxXpReward, minXpReward)
+        );
 
-      const rewardMail = buildMonkeyMail({
-        subject: "Daily leaderboard placement",
-        body: `Congratulations ${entry.name} on placing ${placementString} in the ${language} ${mode} ${mode2} daily leaderboard!`,
-        rewards: [
-          {
-            type: "xp",
-            item: xpReward,
-          },
-        ],
+        const rewardMail = buildMonkeyMail({
+          subject: "Daily leaderboard placement",
+          body: `Congratulations ${entry.name} on placing ${placementString} in the ${language} ${mode} ${mode2} daily leaderboard!`,
+          rewards: [
+            {
+              type: "xp",
+              item: xpReward,
+            },
+          ],
+        });
+
+        return {
+          uid: entry.uid,
+          mail: [rewardMail],
+        };
       });
 
-      return {
-        uid: entry.uid,
-        mail: [rewardMail],
-      };
-    });
-
-    await addToInboxBulk(mailEntries, inboxConfig);
+      await addToInboxBulk(mailEntries, inboxConfig);
+    }
   }
 
   const topResults = allResults.slice(