From 3a065313bf525a86d311d33ab22c050b708b4fb7 Mon Sep 17 00:00:00 2001
From: Miodec <jack@monkeytype.com>
Date: Wed, 15 Jan 2025 10:52:48 +0100
Subject: [PATCH] impr: better email changing logs

!nuf
---
 backend/__tests__/api/controllers/user.spec.ts | 2 +-
 backend/src/api/controllers/user.ts            | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/backend/__tests__/api/controllers/user.spec.ts b/backend/__tests__/api/controllers/user.spec.ts
index d6164eeb6..7b7a38dd5 100644
--- a/backend/__tests__/api/controllers/user.spec.ts
+++ b/backend/__tests__/api/controllers/user.spec.ts
@@ -1068,7 +1068,7 @@ describe("user controller test", () => {
       );
       expect(addImportantLogMock).toHaveBeenCalledWith(
         "user_email_updated",
-        "changed email to newemail@example.com",
+        "changed email from previousemail@example.com to newemail@example.com",
         uid
       );
     });
diff --git a/backend/src/api/controllers/user.ts b/backend/src/api/controllers/user.ts
index 366d0d584..eda361e0d 100644
--- a/backend/src/api/controllers/user.ts
+++ b/backend/src/api/controllers/user.ts
@@ -405,9 +405,10 @@ export async function updateEmail(
   req: MonkeyRequest<undefined, UpdateEmailRequestSchema>
 ): Promise<MonkeyResponse> {
   const { uid } = req.ctx.decodedToken;
-  let { newEmail } = req.body;
+  let { newEmail, previousEmail } = req.body;
 
   newEmail = newEmail.toLowerCase();
+  previousEmail = previousEmail.toLowerCase();
 
   try {
     await AuthUtil.updateUserEmail(uid, newEmail);
@@ -440,7 +441,7 @@ export async function updateEmail(
 
   void addImportantLog(
     "user_email_updated",
-    `changed email to ${newEmail}`,
+    `changed email from ${previousEmail} to ${newEmail}`,
     uid
   );