From 4dafb40cc592ea4a9a4148e6522968cdda3ca63e Mon Sep 17 00:00:00 2001 From: Jack Date: Thu, 22 Jul 2021 17:43:01 +0100 Subject: [PATCH] fixed incomplete last word with a burst spike causing burst heatmap steps to be misrepresented. closes #1655 --- src/js/config.js | 6 ++++-- src/js/test/test-ui.js | 16 +++++++++++++--- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src/js/config.js b/src/js/config.js index 4403e09fb..46e4dcd57 100644 --- a/src/js/config.js +++ b/src/js/config.js @@ -1554,8 +1554,10 @@ export function setBurstHeatmap(value, nosave) { value = false; } config.burstHeatmap = value; - TestUI.applyBurstHeatmap(); - if (!nosave) saveToLocalStorage(); + if (!nosave) { + TestUI.applyBurstHeatmap(); + saveToLocalStorage(); + } } export function apply(configObj) { diff --git a/src/js/test/test-ui.js b/src/js/test/test-ui.js index bff378ffd..a4c68f817 100644 --- a/src/js/test/test-ui.js +++ b/src/js/test/test-ui.js @@ -796,6 +796,16 @@ export function applyBurstHeatmap() { $("#resultWordsHistory .heatmapLegend").removeClass("hidden"); let min = Math.min(...TestStats.burstHistory); let max = Math.max(...TestStats.burstHistory); + + let burstlist = TestStats.burstHistory; + + if ( + TestLogic.input.getHistory(TestLogic.input.getHistory().length - 1) + .length !== TestLogic.words.getCurrent().length + ) { + burstlist = burstlist.splice(0, burstlist.length - 1); + } + // let step = (max - min) / 5; // let steps = [ // { @@ -819,13 +829,13 @@ export function applyBurstHeatmap() { // class: 'heatmap-4' // }, // ]; - let median = Misc.median(TestStats.burstHistory); + let median = Misc.median(burstlist); let adatm = []; - TestStats.burstHistory.forEach((burst) => { + burstlist.forEach((burst) => { adatm.push(Math.abs(median - burst)); }); let step = Misc.mean(adatm); - // let step = Misc.stdDev(TestStats.burstHistory)/2; + // let step = Misc.stdDev(burstlist)/2; let steps = [ { val: 0,