monkeytypegame/monkeytype
1
1
Fork 0
mirror of https://github.com/monkeytypegame/monkeytype.git synced 2026-01-12 18:34:05 +08:00
Code Issues Projects Releases Packages Wiki Activity

refactor: use loadingOptions for leaderboards page

Browse source
This commit is contained in:
Miodec 2025-12-22 22:44:52 +01:00
parent 5d169e933a
commit 765ca9569f
3 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frontend/src/ts/controllers/page-controller.ts
View file

@ -275,9 +275,9 @@ export async function change(
typeof nextPageLoadingMode === "object" &&
nextPageLoadingMode.mode === "async"
) {
nextPageLoadingMode.beforeLoading();
nextPageLoadingMode.beforeLoading?.();
void nextPage?.loadingOptions?.loadingPromise().then(() => {
nextPageLoadingMode.afterLoading();
nextPageLoadingMode.afterLoading?.();
});
}

8
frontend/src/ts/pages/leaderboards.ts
View file

@ -1485,13 +1485,19 @@ export const page = new PageWithUrlParams({
element: qsr(".page.pageLeaderboards"),
path: "/leaderboards",
urlParamsSchema: UrlParameterSchema,
loadingOptions: {
style: "spinner",
loadingMode: () => "sync",
loadingPromise: async () => {
await ServerConfiguration.configurationPromise;
},
},
afterHide: async (): Promise<void> => {
Skeleton.remove("pageLeaderboards");
stopTimer();
},
beforeShow: async (options): Promise<void> => {
await ServerConfiguration.configurationPromise;
Skeleton.append("pageLeaderboards", "main");
await updateValidDailyLeaderboards();
await appendModeAndLanguageButtons();

2
frontend/src/ts/pages/page.ts
View file

@ -34,7 +34,7 @@ export type LoadingOptions = {
loadingMode: () =>
| "none"
| "sync"
| { mode: "async"; beforeLoading: () => void; afterLoading: () => void };
| { mode: "async"; beforeLoading?: () => void; afterLoading?: () => void };
/**
* When this promise resolves, the loading screen will be hidden.
*/