From 89920210d30c7d0b9817607d2d6ed6ccaa9b667d Mon Sep 17 00:00:00 2001
From: Miodec <jack@monkeytype.com>
Date: Fri, 12 Apr 2024 15:34:27 +0200
Subject: [PATCH] impr(account page): change tags, funbox and language filters
 to a multiselect dropdown

closes #5240
---
 frontend/src/html/pages/account.html      |  24 ++-
 frontend/src/styles/account.scss          |  11 +
 frontend/src/styles/z_media-queries.scss  |   4 +
 frontend/src/ts/account/result-filters.ts | 240 +++++++++++++++++++---
 frontend/src/ts/pages/account.ts          |   2 +-
 5 files changed, 241 insertions(+), 40 deletions(-)

diff --git a/frontend/src/html/pages/account.html b/frontend/src/html/pages/account.html
index d3ff32d9b..974d7d1e4 100644
--- a/frontend/src/html/pages/account.html
+++ b/frontend/src/html/pages/account.html
@@ -443,17 +443,19 @@
           <button filter="off">off</button>
         </div>
       </div>
-      <div class="buttonsAndTitle tags" style="grid-column: 1/3">
-        <div class="title">tags</div>
-        <div class="buttons filterGroup" group="tags"></div>
-      </div>
-      <div class="buttonsAndTitle languages" style="grid-column: 1/3">
-        <div class="title">language</div>
-        <div class="buttons filterGroup" group="language"></div>
-      </div>
-      <div class="buttonsAndTitle funbox" style="grid-column: 1/3">
-        <div class="title">funbox</div>
-        <div class="buttons filterGroup" group="funbox"></div>
+      <div class="tripleSelectsColumn">
+        <div class="buttonsAndTitle tags">
+          <div class="title">tags</div>
+          <div class="select filterGroup" group="tags"></div>
+        </div>
+        <div class="buttonsAndTitle funbox">
+          <div class="title">funbox</div>
+          <div class="select filterGroup" group="funbox"></div>
+        </div>
+        <div class="buttonsAndTitle languages">
+          <div class="title">language</div>
+          <div class="select filterGroup" group="language"></div>
+        </div>
       </div>
     </div>
     <div class="group noDataError hidden">
diff --git a/frontend/src/styles/account.scss b/frontend/src/styles/account.scss
index c0219aff1..a3328ff9b 100644
--- a/frontend/src/styles/account.scss
+++ b/frontend/src/styles/account.scss
@@ -409,6 +409,17 @@
     display: grid;
     grid-template-columns: 1fr 1fr;
 
+    .tripleSelectsColumn {
+      grid-column: 1/-1;
+      display: flex;
+      gap: 1rem;
+      flex-wrap: wrap;
+      .buttonsAndTitle {
+        flex-grow: 1;
+        min-width: 20rem;
+      }
+    }
+
     .buttonsAndTitle {
       height: fit-content;
       height: -moz-fit-content;
diff --git a/frontend/src/styles/z_media-queries.scss b/frontend/src/styles/z_media-queries.scss
index 3e7ba895d..13a350553 100644
--- a/frontend/src/styles/z_media-queries.scss
+++ b/frontend/src/styles/z_media-queries.scss
@@ -438,6 +438,10 @@
   .pageAccount .presetFilterButtons .buttons {
     grid-template-columns: 1fr;
   }
+  .pageAccount .group.filterButtons {
+    grid-template-columns: 1fr;
+  }
+
   .pageAccount {
     .triplegroup {
       grid-template-columns: 1fr 1fr;
diff --git a/frontend/src/ts/account/result-filters.ts b/frontend/src/ts/account/result-filters.ts
index 4d86bb12c..c00419cce 100644
--- a/frontend/src/ts/account/result-filters.ts
+++ b/frontend/src/ts/account/result-filters.ts
@@ -6,6 +6,15 @@ import Config from "../config";
 import * as Notifications from "../elements/notifications";
 import Ape from "../ape/index";
 import * as Loader from "../elements/loader";
+import SlimSelect from "slim-select";
+// this is only to make ts happy
+// eslint-disable-next-line import/no-unresolved
+import { Option } from "slim-select/dist/store";
+
+const groupsUsingSelect = ["language", "funbox", "tags"];
+const groupSelects: Partial<
+  Record<keyof SharedTypes.ResultFilters, SlimSelect>
+> = {};
 
 export const defaultResultFilters: SharedTypes.ResultFilters = {
   _id: "default-result-filters-id",
@@ -283,6 +292,14 @@ export function getFilter<G extends keyof SharedTypes.ResultFilters>(
   return filters[group][filter];
 }
 
+function setFilter(
+  group: keyof SharedTypes.ResultFilters,
+  filter: MonkeyTypes.Filter<typeof group>,
+  value: boolean
+): void {
+  filters[group][filter as keyof typeof filters[typeof group]] = value as never;
+}
+
 function setAllFilters(
   group: keyof SharedTypes.ResultFilters,
   value: boolean
@@ -335,24 +352,74 @@ export function updateActive(): void {
           groupAboveChartDisplay.all = false;
         }
       }
-      let buttonEl;
-      if (group === "date") {
-        buttonEl = $(
-          `.pageAccount .group.topFilters .filterGroup[group="${group}"] button[filter="${filter}"]`
+
+      if (groupsUsingSelect.includes(group)) {
+        const option = $(
+          `.pageAccount .group.filterButtons .filterGroup[group="${group}"] option[filter="${filter}"]`
         );
+        if (filterValue === true) {
+          option.prop("selected", true);
+        } else {
+          option.prop("selected", false);
+        }
       } else {
-        buttonEl = $(
-          `.pageAccount .group.filterButtons .filterGroup[group="${group}"] button[filter="${filter}"]`
-        );
-      }
-      if (filterValue === true) {
-        buttonEl.addClass("active");
-      } else {
-        buttonEl.removeClass("active");
+        let buttonEl;
+        if (group === "date") {
+          buttonEl = $(
+            `.pageAccount .group.topFilters .filterGroup[group="${group}"] button[filter="${filter}"]`
+          );
+        } else {
+          buttonEl = $(
+            `.pageAccount .group.filterButtons .filterGroup[group="${group}"] button[filter="${filter}"]`
+          );
+        }
+        if (filterValue === true) {
+          buttonEl.addClass("active");
+        } else {
+          buttonEl.removeClass("active");
+        }
       }
     }
   }
 
+  for (const [id, select] of Object.entries(groupSelects)) {
+    const ss = select;
+    const group = getGroup(id as keyof SharedTypes.ResultFilters);
+    const everythingSelected = Object.values(group).every((v) => v === true);
+
+    const newData = ss.store.getData();
+
+    if (everythingSelected) {
+      for (const data of newData) {
+        //@ts-expect-error
+        if (data.value !== "all") {
+          //@ts-expect-error
+          data.selected = false;
+        } else {
+          //@ts-expect-error
+          data.selected = true;
+        }
+      }
+    } else {
+      for (const data of newData) {
+        //@ts-expect-error
+        if (group[data.value] === true) {
+          //@ts-expect-error
+          data.selected = true;
+        } else {
+          //@ts-expect-error
+          data.selected = false;
+        }
+      }
+    }
+
+    setTimeout(() => {
+      ss.store.setData(newData);
+      ss?.render.renderValues();
+      ss?.render.renderOptions(newData);
+    }, 0);
+  }
+
   function addText(group: keyof SharedTypes.ResultFilters): string {
     let ret = "";
     ret += "<div class='group'>";
@@ -636,7 +703,54 @@ $(".pageAccount .topFilters button.toggleAdvancedFilters").on("click", () => {
   );
 });
 
-export async function appendButtons(): Promise<void> {
+function selectBeforeChangeFn(
+  group: keyof SharedTypes.ResultFilters,
+  selectedOptions: Option[],
+  oldSelectedOptions: Option[]
+): void {
+  const includesAll = selectedOptions.some((option) => option.value === "all");
+  const allIsNew =
+    !oldSelectedOptions.some((option) => option.value === "all") && includesAll;
+
+  if (includesAll) {
+    if (allIsNew) {
+      selectedOptions = selectedOptions.filter(
+        (option) => option.value === "all"
+      );
+    } else if (selectedOptions.length > 1) {
+      selectedOptions = selectedOptions.filter(
+        (option) => option.value !== "all"
+      );
+    }
+  }
+
+  setAllFilters(group, false);
+  for (const selectedOption of selectedOptions) {
+    if (selectedOption.value === "all") {
+      setAllFilters(group, true);
+      updateActive();
+      save();
+      selectChangeCallbackFn();
+      break;
+    }
+
+    setFilter(group, selectedOption.value, true);
+  }
+
+  updateActive();
+  save();
+  selectChangeCallbackFn();
+}
+
+let selectChangeCallbackFn: () => void = () => {
+  //
+};
+
+export async function appendButtons(
+  selectChangeCallback: () => void
+): Promise<void> {
+  selectChangeCallbackFn = selectChangeCallback;
+
   let languageList;
   try {
     languageList = await JSONData.getLanguageList();
@@ -647,15 +761,42 @@ export async function appendButtons(): Promise<void> {
   }
   if (languageList) {
     let html = "";
+
+    html +=
+      "<select class='languageSelect' group='language' placeholder='select a language' multiple>";
+
+    html += "<option value='all'>all</option>";
+
     for (const language of languageList) {
-      html += `<button filter="${language}">${Strings.getLanguageDisplayString(
+      html += `<option value="${language}" filter="${language}">${Strings.getLanguageDisplayString(
         language
-      )}</button>`;
+      )}</option>`;
     }
+
+    html += "</select>";
+
     const el = document.querySelector(
-      ".pageAccount .content .filterButtons .buttonsAndTitle.languages .buttons"
+      ".pageAccount .content .filterButtons .buttonsAndTitle.languages .select"
     );
-    if (el) el.innerHTML = html;
+    if (el) {
+      el.innerHTML = html;
+      groupSelects["language"] = new SlimSelect({
+        select: el.querySelector(".languageSelect") as HTMLSelectElement,
+        settings: {
+          showSearch: true,
+          placeholderText: "select a language",
+        },
+        events: {
+          beforeChange: (selectedOptions, oldSelectedOptions): void => {
+            selectBeforeChangeFn(
+              "language",
+              selectedOptions,
+              oldSelectedOptions
+            );
+          },
+        },
+      });
+    }
   }
 
   let funboxList;
@@ -668,35 +809,78 @@ export async function appendButtons(): Promise<void> {
   }
   if (funboxList) {
     let html = "";
+
+    html +=
+      "<select class='funboxSelect' group='funbox' placeholder='select a funbox' multiple>";
+
+    html += "<option value='all'>all</option>";
+
     for (const funbox of funboxList) {
-      html += `<button filter="${funbox.name}">${funbox.name.replace(
-        /_/g,
-        " "
-      )}</button>`;
+      html += `<option value="${funbox.name}" filter="${
+        funbox.name
+      }">${funbox.name.replace(/_/g, " ")}</option>`;
     }
+
+    html += "</select>";
+
     const el = document.querySelector(
-      ".pageAccount .content .filterButtons .buttonsAndTitle.funbox .buttons"
+      ".pageAccount .content .filterButtons .buttonsAndTitle.funbox .select"
     );
     if (el) {
-      el.innerHTML = `<button filter="none">none</button>` + html;
+      el.innerHTML = html;
+      groupSelects["funbox"] = new SlimSelect({
+        select: el.querySelector(".funboxSelect") as HTMLSelectElement,
+        settings: {
+          showSearch: true,
+          placeholderText: "select a funbox",
+        },
+        events: {
+          beforeChange: (selectedOptions, oldSelectedOptions): void => {
+            selectBeforeChangeFn("funbox", selectedOptions, oldSelectedOptions);
+          },
+        },
+      });
     }
   }
 
   const snapshot = DB.getSnapshot();
 
-  if ((snapshot?.tags?.length ?? 0) > 0) {
+  if (snapshot !== undefined && (snapshot.tags?.length ?? 0) > 0) {
     $(".pageAccount .content .filterButtons .buttonsAndTitle.tags").removeClass(
       "hidden"
     );
-    let html = `<button filter="none">no tag</button>`;
-    for (const tag of snapshot?.tags ?? []) {
-      html += `<button filter="${tag._id}">${tag.display}</button>`;
+
+    let html = "";
+
+    html +=
+      "<select class='tagsSelect' group='tags' placeholder='select a tag' multiple>";
+
+    html += "<option value='all'>all</option>";
+    html += "<option value='none'>no tag</option>";
+
+    for (const tag of snapshot.tags) {
+      html += `<option value="${tag._id}" filter="${tag.name}">${tag.display}</option>`;
     }
+
+    html += "</select>";
+
     const el = document.querySelector(
-      ".pageAccount .content .filterButtons .buttonsAndTitle.tags .buttons"
+      ".pageAccount .content .filterButtons .buttonsAndTitle.tags .select"
     );
     if (el) {
       el.innerHTML = html;
+      groupSelects["tags"] = new SlimSelect({
+        select: el.querySelector(".tagsSelect") as HTMLSelectElement,
+        settings: {
+          showSearch: true,
+          placeholderText: "select a tag",
+        },
+        events: {
+          beforeChange: (selectedOptions, oldSelectedOptions): void => {
+            selectBeforeChangeFn("tags", selectedOptions, oldSelectedOptions);
+          },
+        },
+      });
     }
   } else {
     $(".pageAccount .content .filterButtons .buttonsAndTitle.tags").addClass(
diff --git a/frontend/src/ts/pages/account.ts b/frontend/src/ts/pages/account.ts
index 4892abd07..0f5cf42f0 100644
--- a/frontend/src/ts/pages/account.ts
+++ b/frontend/src/ts/pages/account.ts
@@ -1275,7 +1275,7 @@ export const page = new Page({
       $(".pageAccount .preloader").removeClass("hidden");
       await LoadingPage.showBar();
     }
-    await ResultFilters.appendButtons();
+    await ResultFilters.appendButtons(update);
     ResultFilters.updateActive();
     await Misc.sleep(0);