From a1a94db1a30a741fe72c608a7ba2db7ba405b834 Mon Sep 17 00:00:00 2001
From: Miodec <jack@monkeytype.com>
Date: Thu, 25 Jul 2024 10:54:01 +0200
Subject: [PATCH] impr(authentication): error message when sign in popup was
 blocked by the browser

fixes #5530
---
 frontend/src/ts/controllers/account-controller.ts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/frontend/src/ts/controllers/account-controller.ts b/frontend/src/ts/controllers/account-controller.ts
index 6f465784e..d9fb1a938 100644
--- a/frontend/src/ts/controllers/account-controller.ts
+++ b/frontend/src/ts/controllers/account-controller.ts
@@ -381,6 +381,9 @@ async function signInWithProvider(provider: AuthProvider): Promise<void> {
         message = "";
         // message = "Popup closed by user";
         // return;
+      } else if (error.code === "auth/popup-blocked") {
+        message =
+          "Sign in popup was blocked by the browser. Check the address bar for a blocked popup icon, or update your browser settings to allow popups.";
       } else if (error.code === "auth/user-cancelled") {
         message = "";
         // message = "User refused to sign in";