From a59f99a5331bbefc185762500a4443fa699140c8 Mon Sep 17 00:00:00 2001
From: Miodec <jack@monkeytype.com>
Date: Sat, 26 Apr 2025 18:56:58 +0200
Subject: [PATCH] refactor: protect against null, remove nullish coalescing

---
 backend/src/services/weekly-xp-leaderboard.ts | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/backend/src/services/weekly-xp-leaderboard.ts b/backend/src/services/weekly-xp-leaderboard.ts
index 70f7064b5..f7a510ac7 100644
--- a/backend/src/services/weekly-xp-leaderboard.ts
+++ b/backend/src/services/weekly-xp-leaderboard.ts
@@ -221,17 +221,14 @@ export class WeeklyXpLeaderboard {
       [null, string | null]
     ];
 
-    if (rank === null) {
+    if (rank === null || result === null) {
       return null;
     }
 
     // safely parse the result with error handling
     let parsed: RedisXpLeaderboardEntry;
     try {
-      parsed = parseJsonWithSchema(
-        result ?? "null",
-        RedisXpLeaderboardEntrySchema
-      );
+      parsed = parseJsonWithSchema(result, RedisXpLeaderboardEntrySchema);
     } catch (error) {
       throw new MonkeyError(
         500,