monkeytypegame/monkeytype
1
1
Fork 0
mirror of https://github.com/monkeytypegame/monkeytype.git synced 2025-10-09 23:25:53 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix: unhelpful error messages when custom background image was not a valid url

Browse source
This commit is contained in:
Miodec 2025-04-10 14:28:13 +02:00
parent 248de12f63
commit a7f4dcf9e0
2 changed files with 43 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
frontend/src/ts/commandline/lists.ts
View file

@ -106,7 +106,10 @@ import * as TestStats from "../test/test-stats";
import * as QuoteSearchModal from "../modals/quote-search";
import * as FPSCounter from "../elements/fps-counter";
import { migrateConfig } from "../utils/config";
import { PartialConfigSchema } from "@monkeytype/contracts/schemas/configs";
import {
CustomBackgroundSchema,
PartialConfigSchema,
} from "@monkeytype/contracts/schemas/configs";
import { Command, CommandsSubgroup } from "./types";
import { parseWithSchema as parseJsonWithSchema } from "@monkeytype/util/json";
@ -307,6 +310,14 @@ export const commands: CommandsSubgroup = {
},
input: true,
exec: ({ input }): void => {
const parsed = CustomBackgroundSchema.safeParse(input);
if (!parsed.success) {
Notifications.add(
`Invalid custom background URL (${parsed.error.issues[0]?.message})`,
0
);
return;
}
UpdateConfig.setCustomBackground(input ?? "");
},
},

41
frontend/src/ts/pages/settings.ts
View file

@ -22,6 +22,7 @@ import * as Skeleton from "../utils/skeleton";
import * as CustomBackgroundFilter from "../elements/custom-background-filter";
import {
ConfigValue,
CustomBackgroundSchema,
CustomLayoutFluid,
} from "@monkeytype/contracts/schemas/configs";
import {
@ -1108,11 +1109,21 @@ $(".pageSettings .sectionGroupTitle").on("click", (e) => {
$(
".pageSettings .section[data-config-name='customBackgroundSize'] .inputAndButton button.save"
).on("click", () => {
UpdateConfig.setCustomBackground(
$(
".pageSettings .section[data-config-name='customBackgroundSize'] .inputAndButton input"
).val() as string
);
const newVal = $(
".pageSettings .section[data-config-name='customBackgroundSize'] .inputAndButton input"
).val() as string;
const parsed = CustomBackgroundSchema.safeParse(newVal);
if (!parsed.success) {
Notifications.add(
`Invalid custom background URL (${parsed.error.issues[0]?.message})`,
0
);
return;
}
UpdateConfig.setCustomBackground(newVal);
});
$(
@ -1125,11 +1136,21 @@ $(
".pageSettings .section[data-config-name='customBackgroundSize'] .inputAndButton input"
).on("keypress", (e) => {
if (e.key === "Enter") {
UpdateConfig.setCustomBackground(
$(
".pageSettings .section[data-config-name='customBackgroundSize'] .inputAndButton input"
).val() as string
);
const newVal = $(
".pageSettings .section[data-config-name='customBackgroundSize'] .inputAndButton input"
).val() as string;
const parsed = CustomBackgroundSchema.safeParse(newVal);
if (!parsed.success) {
Notifications.add(
`Invalid custom background URL (${parsed.error.issues[0]?.message})`,
0
);
return;
}
UpdateConfig.setCustomBackground(newVal);
}
});