From aa94a8afed6cee0f94fc9f72b158b28af5924ea2 Mon Sep 17 00:00:00 2001 From: Christian Fehmer Date: Wed, 30 Jul 2025 10:06:04 +0200 Subject: [PATCH] chore: update nodejs to 20.19.4 (@fehmer) (#6805) --- .github/workflows/monkey-ci.yml | 2 +- .github/workflows/pretty-check.yml | 2 +- .github/workflows/pretty-fix.yml | 2 +- .nvmrc | 2 +- backend/docker/compose.yml | 2 +- backend/package.json | 2 +- docker/backend/Dockerfile | 4 ++-- docker/frontend/Dockerfile | 2 +- docs/CONTRIBUTING_ADVANCED.md | 6 +++--- frontend/docker/compose.dev.yml | 2 +- frontend/package.json | 2 +- package.json | 2 +- 12 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/monkey-ci.yml b/.github/workflows/monkey-ci.yml index f949f1bc3..a3bf2761b 100644 --- a/.github/workflows/monkey-ci.yml +++ b/.github/workflows/monkey-ci.yml @@ -2,7 +2,7 @@ name: Monkey CI env: PNPM_VERSION: "9.6.0" - NODE_VERSION: "20.16.0" + NODE_VERSION: "20.19.4" RECAPTCHA_SITE_KEY: "6Lc-V8McAAAAAJ7s6LGNe7MBZnRiwbsbiWts87aj" permissions: diff --git a/.github/workflows/pretty-check.yml b/.github/workflows/pretty-check.yml index 0f6b59d31..dd49c1314 100644 --- a/.github/workflows/pretty-check.yml +++ b/.github/workflows/pretty-check.yml @@ -2,7 +2,7 @@ name: Prettier Check env: PNPM_VERSION: "9.6.0" - NODE_VERSION: "20.16.0" + NODE_VERSION: "20.19.4" on: pull_request: diff --git a/.github/workflows/pretty-fix.yml b/.github/workflows/pretty-fix.yml index 90d7d154b..c9c921ad3 100644 --- a/.github/workflows/pretty-fix.yml +++ b/.github/workflows/pretty-fix.yml @@ -2,7 +2,7 @@ name: Prettier Fix env: PNPM_VERSION: "9.6.0" - NODE_VERSION: "20.16.0" + NODE_VERSION: "20.19.4" permissions: contents: write diff --git a/.nvmrc b/.nvmrc index 593cb75bc..5b811e532 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -20.16.0 \ No newline at end of file +20.19.4 \ No newline at end of file diff --git a/backend/docker/compose.yml b/backend/docker/compose.yml index 0100bedd4..539b45ccd 100644 --- a/backend/docker/compose.yml +++ b/backend/docker/compose.yml @@ -23,7 +23,7 @@ services: container_name: monkeytype-api-server build: dockerfile_inline: | - FROM node:20.16.0 + FROM node:20.19.4 RUN npm i -g pnpm@9.6.0 RUN mkdir /pnpm-store && chown -R 1000:1000 /pnpm-store user: "node" ##this works as long as your local user has uid=1000 diff --git a/backend/package.json b/backend/package.json index 146b4cf56..6e35f2544 100644 --- a/backend/package.json +++ b/backend/package.json @@ -21,7 +21,7 @@ "gen-docs": "tsx scripts/openapi.ts dist/static/api/openapi.json && redocly build-docs -o dist/static/api/internal.html internal@v2 && redocly bundle -o dist/static/api/public.json public-filter && redocly build-docs -o dist/static/api/public.html public@v2" }, "engines": { - "node": "20.16.0" + "node": "20.19.4" }, "dependencies": { "@date-fns/utc": "1.2.0", diff --git a/docker/backend/Dockerfile b/docker/backend/Dockerfile index 99d54c36e..f10446013 100644 --- a/docker/backend/Dockerfile +++ b/docker/backend/Dockerfile @@ -1,4 +1,4 @@ -FROM node:20.16.0-alpine3.19 AS builder +FROM node:20.19.4-alpine3.19 AS builder WORKDIR /app @@ -18,7 +18,7 @@ RUN pnpm deploy --filter backend --prod /prod/backend #--------------------------------- ## target image -FROM node:20.16.0-alpine3.19 +FROM node:20.19.4-alpine3.19 ## get server_version from build-arg, default to UNKNOWN ARG server_version=UNKNOWN diff --git a/docker/frontend/Dockerfile b/docker/frontend/Dockerfile index c8911fdb5..4d73d1767 100644 --- a/docker/frontend/Dockerfile +++ b/docker/frontend/Dockerfile @@ -1,4 +1,4 @@ -FROM node:20.16.0-alpine3.19 AS builder +FROM node:20.19.4-alpine3.19 AS builder WORKDIR /app #ENV diff --git a/docs/CONTRIBUTING_ADVANCED.md b/docs/CONTRIBUTING_ADVANCED.md index 9d360f9ac..4538f51bf 100644 --- a/docs/CONTRIBUTING_ADVANCED.md +++ b/docs/CONTRIBUTING_ADVANCED.md @@ -21,7 +21,7 @@ ## Prerequisites -This contribution guide is for cases in which you need to test the functionality of your changes, or if you need to take screenshots of your changes. You will need a computer with a stable internet connection, a text editor, Git, and NodeJS with version 20.16.0. There are some additional requirements depending on what you're looking to contribute, such as Firebase for authentication, and Mongo and Docker for the backend. Read the below sections to understand how to set up each of these tools. +This contribution guide is for cases in which you need to test the functionality of your changes, or if you need to take screenshots of your changes. You will need a computer with a stable internet connection, a text editor, Git, and NodeJS with version 20.19.4. There are some additional requirements depending on what you're looking to contribute, such as Firebase for authentication, and Mongo and Docker for the backend. Read the below sections to understand how to set up each of these tools. ### Git @@ -33,9 +33,9 @@ Git is optional but we recommend you utilize it. Monkeytype uses the Git source ### NodeJS and PNPM -Currently, the project is using version `20.16.0 LTS`. +Currently, the project is using version `20.19.4 LTS`. -If you use `nvm` (if you use Windows, use [nvm-windows](https://github.com/coreybutler/nvm-windows)) then you can run `nvm install` and `nvm use` (you might need to specify the exact version eg: `nvm install 20.16.0` then `nvm use 20.16.0`) to use the version of Node.js in the `.nvmrc` file. +If you use `nvm` (if you use Windows, use [nvm-windows](https://github.com/coreybutler/nvm-windows)) then you can run `nvm install` and `nvm use` (you might need to specify the exact version eg: `nvm install 20.19.4` then `nvm use 20.19.4`) to use the version of Node.js in the `.nvmrc` file. Alternatively, you can navigate to the NodeJS [website](https://nodejs.org/en/) to download it from there. diff --git a/frontend/docker/compose.dev.yml b/frontend/docker/compose.dev.yml index 10710eb57..1eedc9d5d 100644 --- a/frontend/docker/compose.dev.yml +++ b/frontend/docker/compose.dev.yml @@ -4,7 +4,7 @@ services: container_name: monkeytype-frontend build: dockerfile_inline: | - FROM node:20.16.0 + FROM node:20.19.4 RUN npm i -g pnpm@9.6.0 RUN mkdir /pnpm-store && chown -R 1000:1000 /pnpm-store user: "node" ##this works as long as your local user has uid=1000 diff --git a/frontend/package.json b/frontend/package.json index e27f444d3..6c1e9f343 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -25,7 +25,7 @@ "docker": "docker compose -f docker/compose.dev.yml up" }, "engines": { - "node": "20.16.0" + "node": "20.19.4" }, "browserslist": [ "defaults", diff --git a/package.json b/package.json index 3ab87081f..3e7aaf01a 100644 --- a/package.json +++ b/package.json @@ -59,7 +59,7 @@ "pr-check-other-json": "cd frontend && npx gulp pr-check-other-json && turbo test -- constants/layouts constants/themes constants/fonts" }, "engines": { - "node": "20.16.0" + "node": "20.19.4" }, "devDependencies": { "@commitlint/cli": "17.7.1",