From b059b72c6bc78872ea6ea4b5f1b516d59688abe0 Mon Sep 17 00:00:00 2001 From: Miodec Date: Thu, 13 Apr 2023 15:33:15 +0200 Subject: [PATCH 1/2] stupid mistakes man --- frontend/src/ts/controllers/input-controller.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/frontend/src/ts/controllers/input-controller.ts b/frontend/src/ts/controllers/input-controller.ts index d92b71ba5..7f8cee052 100644 --- a/frontend/src/ts/controllers/input-controller.ts +++ b/frontend/src/ts/controllers/input-controller.ts @@ -1009,8 +1009,6 @@ $("#wordsInput").keyup((event) => { event.code = "Space"; //powertoys bug } - event.code = ""; - const now = performance.now(); setTimeout(() => { const eventCode = event.code === "" ? "NoCode" : event.code; From 9f72a193e102ad6642f38e4d0d6a13cfea1dc317 Mon Sep 17 00:00:00 2001 From: Miodec Date: Thu, 13 Apr 2023 17:46:47 +0200 Subject: [PATCH 2/2] trying a new approach to NoCode to cover more edge cases --- .../src/ts/controllers/input-controller.ts | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/frontend/src/ts/controllers/input-controller.ts b/frontend/src/ts/controllers/input-controller.ts index 7f8cee052..78d1831c7 100644 --- a/frontend/src/ts/controllers/input-controller.ts +++ b/frontend/src/ts/controllers/input-controller.ts @@ -987,13 +987,14 @@ $("#wordsInput").keydown((event) => { console.log("spacing debug keydown", event.key, event.code, event.which); } - if (event.key === " ") { - event.code = "Space"; //powertoys bug - } + // if (event.key === " ") { + // event.code = "Space"; //powertoys bug + // } const now = performance.now(); setTimeout(() => { - const eventCode = event.code === "" ? "NoCode" : event.code; + const eventCode = + event.code === "" || event.which === 231 ? "NoCode" : event.code; TestInput.recordKeydownTime(now, eventCode); }, 0); }); @@ -1005,13 +1006,14 @@ $("#wordsInput").keyup((event) => { console.log("spacing debug keyup", event.key, event.code, event.which); } - if (event.key === " ") { - event.code = "Space"; //powertoys bug - } + // if (event.key === " ") { + // event.code = "Space"; //powertoys bug + // } const now = performance.now(); setTimeout(() => { - const eventCode = event.code === "" ? "NoCode" : event.code; + const eventCode = + event.code === "" || event.which === 231 ? "NoCode" : event.code; TestInput.recordKeyupTime(now, eventCode); }, 0); });