From ab9cef010ef66c70856834c1f4e0aa0e8526c88d Mon Sep 17 00:00:00 2001
From: Miodec <jack@monkeytype.com>
Date: Sat, 26 Apr 2025 21:41:39 +0200
Subject: [PATCH] chore: swap monkeyerror for error to not expose actual error
 message to the frontend

---
 backend/src/services/weekly-xp-leaderboard.ts |  8 +++-----
 backend/src/utils/daily-leaderboards.ts       | 10 ++++------
 2 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/backend/src/services/weekly-xp-leaderboard.ts b/backend/src/services/weekly-xp-leaderboard.ts
index 8dd82ca84..7f79256ff 100644
--- a/backend/src/services/weekly-xp-leaderboard.ts
+++ b/backend/src/services/weekly-xp-leaderboard.ts
@@ -180,8 +180,7 @@ export class WeeklyXpLeaderboard {
             totalXp: parseInt(scoreValue, 10),
           };
         } catch (error) {
-          throw new MonkeyError(
-            500,
+          throw new Error(
             `Failed to parse leaderboard entry at index ${index}: ${
               error instanceof Error ? error.message : String(error)
             }`
@@ -203,7 +202,7 @@ export class WeeklyXpLeaderboard {
   ): Promise<XpLeaderboardEntry | null> {
     const connection = RedisClient.getConnection();
     if (!connection || !weeklyXpLeaderboardConfig.enabled) {
-      throw new MonkeyError(500, "Redis connection is unavailable");
+      throw new Error("Redis connection is unavailable");
     }
 
     const { weeklyXpLeaderboardScoresKey, weeklyXpLeaderboardResultsKey } =
@@ -231,8 +230,7 @@ export class WeeklyXpLeaderboard {
     );
 
     if (error) {
-      throw new MonkeyError(
-        500,
+      throw new Error(
         `Failed to parse leaderboard entry: ${
           error instanceof Error ? error.message : String(error)
         }`
diff --git a/backend/src/utils/daily-leaderboards.ts b/backend/src/utils/daily-leaderboards.ts
index 038885d47..b0f160046 100644
--- a/backend/src/utils/daily-leaderboards.ts
+++ b/backend/src/utils/daily-leaderboards.ts
@@ -157,8 +157,7 @@ export class DailyLeaderboard {
             rank: minRank + index + 1,
           };
         } catch (error) {
-          throw new MonkeyError(
-            500,
+          throw new Error(
             `Failed to parse leaderboard entry at index ${index}: ${
               error instanceof Error ? error.message : String(error)
             }`
@@ -203,7 +202,7 @@ export class DailyLeaderboard {
   ): Promise<LeaderboardEntry | null> {
     const connection = RedisClient.getConnection();
     if (!connection || !dailyLeaderboardsConfig.enabled) {
-      throw new MonkeyError(500, "Redis connection is unavailable");
+      throw new Error("Redis connection is unavailable");
     }
 
     const { leaderboardScoresKey, leaderboardResultsKey } =
@@ -235,8 +234,7 @@ export class DailyLeaderboard {
         rank: rank + 1,
       };
     } catch (error) {
-      throw new MonkeyError(
-        500,
+      throw new Error(
         `Failed to parse leaderboard entry: ${
           error instanceof Error ? error.message : String(error)
         }`
@@ -247,7 +245,7 @@ export class DailyLeaderboard {
   public async getCount(): Promise<number> {
     const connection = RedisClient.getConnection();
     if (!connection) {
-      throw new MonkeyError(500, "Redis connection is unavailable");
+      throw new Error("Redis connection is unavailable");
     }
 
     const { leaderboardScoresKey } = this.getTodaysLeaderboardKeys();