monkeytypegame/monkeytype
1
1
Fork 0
mirror of https://github.com/monkeytypegame/monkeytype.git synced 2024-11-10 08:55:37 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix: too many decimals showing on profile page for some users (fehmer) (#5433)

Browse source
This commit is contained in:
Christian Fehmer 2024-05-23 12:56:55 +02:00 committed by GitHub
parent 57b06eff18
commit b19ff0d9bd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 50 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
frontend/__tests__/utils/numbers.spec.ts Normal file
View file

@ -0,0 +1,49 @@
import * as Numbers from "../../src/ts/utils/numbers";
describe("numbers", () => {
describe("abbreviateNumber", () => {
it("should round to one decimal by default", () => {
expect(Numbers.abbreviateNumber(1)).toEqual("1.0");
expect(Numbers.abbreviateNumber(1.5)).toEqual("1.5");
expect(Numbers.abbreviateNumber(1.55)).toEqual("1.6");
expect(Numbers.abbreviateNumber(1000)).toEqual("1.0k");
expect(Numbers.abbreviateNumber(1010)).toEqual("1.0k");
expect(Numbers.abbreviateNumber(1099)).toEqual("1.1k");
});
it("should round to full numbers", () => {
expect(Numbers.abbreviateNumber(1, 0)).toEqual("1");
expect(Numbers.abbreviateNumber(1.5, 0)).toEqual("2");
expect(Numbers.abbreviateNumber(1.55, 0)).toEqual("2");
expect(Numbers.abbreviateNumber(1000, 0)).toEqual("1k");
expect(Numbers.abbreviateNumber(1010, 0)).toEqual("1k");
expect(Numbers.abbreviateNumber(1099, 0)).toEqual("1k");
});
it("should round to two decimals", () => {
expect(Numbers.abbreviateNumber(1, 2)).toEqual("1.00");
expect(Numbers.abbreviateNumber(1.5, 2)).toEqual("1.50");
expect(Numbers.abbreviateNumber(1.55, 2)).toEqual("1.55");
expect(Numbers.abbreviateNumber(1000, 2)).toEqual("1.00k");
expect(Numbers.abbreviateNumber(1010, 2)).toEqual("1.01k");
expect(Numbers.abbreviateNumber(1099, 2)).toEqual("1.10k");
});
it("should use suffixes", () => {
let number = 1;
expect(Numbers.abbreviateNumber(number)).toEqual("1.0");
expect(Numbers.abbreviateNumber((number *= 1000))).toEqual("1.0k");
expect(Numbers.abbreviateNumber((number *= 1000))).toEqual("1.0m");
expect(Numbers.abbreviateNumber((number *= 1000))).toEqual("1.0b");
expect(Numbers.abbreviateNumber((number *= 1000))).toEqual("1.0t");
expect(Numbers.abbreviateNumber((number *= 1000))).toEqual("1.0q");
expect(Numbers.abbreviateNumber((number *= 1000))).toEqual("1.0Q");
expect(Numbers.abbreviateNumber((number *= 1000))).toEqual("1.0s");
expect(Numbers.abbreviateNumber((number *= 1000))).toEqual("1.0S");
expect(Numbers.abbreviateNumber((number *= 1000))).toEqual("1.0o");
expect(Numbers.abbreviateNumber((number *= 1000))).toEqual("1.0n");
expect(Numbers.abbreviateNumber((number *= 1000))).toEqual("1.0d");
});
});
});

2
frontend/src/ts/utils/numbers.ts
View file

@ -146,7 +146,7 @@ export function getNumberWithMagnitude(num: number): {
*/
export function abbreviateNumber(num: number, decimalPoints = 1): string {
if (num < 1000) {
return num.toString();
return num.toFixed(decimalPoints);
}
const exp = Math.floor(Math.log(num) / Math.log(1000));