chore: move withobjectid to backend types

backend/__tests__/dal/result.spec.ts

@@ -2,7 +2,9 @@ import * as ResultDal from "../../src/dal/result";
 import { ObjectId } from "mongodb";
 import * as UserDal from "../../src/dal/user";
 
-type MonkeyTypesResult = SharedTypes.DBResult<SharedTypes.Config.Mode>;
+type MonkeyTypesResult = MonkeyTypes.WithObjectId<
+  SharedTypes.DBResult<SharedTypes.Config.Mode>
+>;
 
 let uid: string = "";
 const timestamp = Date.now() - 60000;

backend/src/dal/result.ts

@@ -5,7 +5,9 @@ import * as db from "../init/db";
 
 import { getUser, getTags } from "./user";
 
-type DBResult = SharedTypes.DBResult<SharedTypes.Config.Mode>;
+type DBResult = MonkeyTypes.WithObjectId<
+  SharedTypes.DBResult<SharedTypes.Config.Mode>
+>;
 
 export async function addResult(
   uid: string,

backend/src/utils/result.ts

@@ -1,6 +1,8 @@
 import { ObjectId } from "mongodb";
 
-type Result = SharedTypes.DBResult<SharedTypes.Config.Mode>;
+type Result = MonkeyTypes.WithObjectId<
+  SharedTypes.DBResult<SharedTypes.Config.Mode>
+>;
 
 export function buildDbResult(
   completedEvent: SharedTypes.CompletedEvent,

shared-types/types.d.ts

@@ -189,53 +189,47 @@ declare namespace SharedTypes {
     textLen?: number;
   }
 
-  type WithObjectId<T extends { _id: string }> = Omit<T, "_id"> & {
-    _id: ObjectId;
+  type DBResult<T extends SharedTypes.Config.Mode> = Omit<
+    SharedTypes.Result<T>,
+    | "bailedOut"
+    | "blindMode"
+    | "lazyMode"
+    | "difficulty"
+    | "funbox"
+    | "language"
+    | "numbers"
+    | "punctuation"
+    | "restartCount"
+    | "incompleteTestSeconds"
+    | "afkDuration"
+    | "tags"
+    | "incompleteTests"
+    | "customText"
+    | "quoteLength"
+    | "isPb"
+  > & {
+    correctChars?: number; // --------------
+    incorrectChars?: number; // legacy results
+    // --------------
+    name: string;
+    // -------------- fields that might be removed to save space
+    bailedOut?: boolean;
+    blindMode?: boolean;
+    lazyMode?: boolean;
+    difficulty?: SharedTypes.Config.Difficulty;
+    funbox?: string;
+    language?: string;
+    numbers?: boolean;
+    punctuation?: boolean;
+    restartCount?: number;
+    incompleteTestSeconds?: number;
+    afkDuration?: number;
+    tags?: string[];
+    customText?: CustomText;
+    quoteLength?: number;
+    isPb?: boolean;
   };
 
-  type DBResult<T extends SharedTypes.Config.Mode> = WithObjectId<
-    Omit<
-      SharedTypes.Result<T>,
-      | "bailedOut"
-      | "blindMode"
-      | "lazyMode"
-      | "difficulty"
-      | "funbox"
-      | "language"
-      | "numbers"
-      | "punctuation"
-      | "restartCount"
-      | "incompleteTestSeconds"
-      | "afkDuration"
-      | "tags"
-      | "incompleteTests"
-      | "customText"
-      | "quoteLength"
-      | "isPb"
-    > & {
-      correctChars?: number; // --------------
-      incorrectChars?: number; // legacy results
-      // --------------
-      name: string;
-      // -------------- fields that might be removed to save space
-      bailedOut?: boolean;
-      blindMode?: boolean;
-      lazyMode?: boolean;
-      difficulty?: SharedTypes.Config.Difficulty;
-      funbox?: string;
-      language?: string;
-      numbers?: boolean;
-      punctuation?: boolean;
-      restartCount?: number;
-      incompleteTestSeconds?: number;
-      afkDuration?: number;
-      tags?: string[];
-      customText?: CustomText;
-      quoteLength?: number;
-      isPb?: boolean;
-    }
-  >;
-
   interface CompletedEvent extends Result<SharedTypes.Config.Mode> {
     keySpacing: number[] | "toolong";
     keyDuration: number[] | "toolong";