monkeytypegame/monkeytype
1
1
Fork 0
mirror of https://github.com/monkeytypegame/monkeytype.git synced 2025-02-05 13:27:49 +08:00
Code Issues Projects Releases Packages Wiki Activity

Remove private methods from simplePopup

Browse source 
The added simplePopup had private methods, which totally breaks Firefox and Safari since it's a syntax error and this file then doesn't load at all. We can simply make these methods public, there's no reason they need to be private to work, it's just a code organization thing.
This commit is contained in:
Joel Bradshaw 2020-10-30 01:06:46 -07:00 committed by GitHub
parent bc45bc6d52
commit c8764790b8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
public/js/misc.js
View file

@ -510,7 +510,7 @@ class SimplePopup {
this.element = $("#simplePopup");
this.buttonText = buttonText;
}
#reset() {
reset() {
this.element.html(`
<div class="title"></div>
<input>
@ -518,11 +518,11 @@ class SimplePopup {
<div class="button"></div>`);
}
#init() {
init() {
let el = this.element;
el.find("input").val("");
if (el.attr("popupId") !== this.id) {
this.#reset();
this.reset();
el.attr("popupId", this.id);
el.find(".title").text(this.title);
el.find(".text").text(this.text);
@ -546,7 +546,7 @@ class SimplePopup {
}
show() {
this.#init();
this.init();
this.wrapper
.stop(true, true)
.css("opacity", 0)