From da97eb06fb018c3613c3bef1938e98962d20fdf5 Mon Sep 17 00:00:00 2001 From: Miodec Date: Sat, 1 Jan 2022 15:52:50 +0100 Subject: [PATCH] added a check if the click is inside the popup --- src/js/popups/contact-popup.js | 14 ++++++++------ src/js/popups/version-popup.js | 14 ++++++++------ 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/src/js/popups/contact-popup.js b/src/js/popups/contact-popup.js index 6db1e545c..22c468b59 100644 --- a/src/js/popups/contact-popup.js +++ b/src/js/popups/contact-popup.js @@ -5,10 +5,12 @@ $(document.body).on("click", "#contactPopupButton", () => { .animate({ opacity: 1 }, 125); }); -$(document.body).on("click", "#contactPopupWrapper", () => { - $("#contactPopupWrapper") - .css("opacity", 1) - .animate({ opacity: 0 }, 125, () => { - $("#contactPopupWrapper").addClass("hidden"); - }); +$(document.body).on("click", "#contactPopupWrapper", (e) => { + if ($(e.target).attr("id") === "contactPopupWrapper") { + $("#contactPopupWrapper") + .css("opacity", 1) + .animate({ opacity: 0 }, 125, () => { + $("#contactPopupWrapper").addClass("hidden"); + }); + } }); diff --git a/src/js/popups/version-popup.js b/src/js/popups/version-popup.js index 62ab426d1..adc7309e4 100644 --- a/src/js/popups/version-popup.js +++ b/src/js/popups/version-popup.js @@ -9,10 +9,12 @@ $(document.body).on("click", ".version", () => { show(); }); -$(document.body).on("click", "#versionHistoryWrapper", () => { - $("#versionHistoryWrapper") - .css("opacity", 1) - .animate({ opacity: 0 }, 125, () => { - $("#versionHistoryWrapper").addClass("hidden"); - }); +$(document.body).on("click", "#versionHistoryWrapper", (e) => { + if ($(e.target).attr("id") === "versionHistoryWrapper") { + $("#versionHistoryWrapper") + .css("opacity", 1) + .animate({ opacity: 0 }, 125, () => { + $("#versionHistoryWrapper").addClass("hidden"); + }); + } });