Move dependencies (#2483)

* Move dependencies

* Fixes

* Add stale pr action

* Update

* Fix cron schedule

.github/workflows/stale-pr.yml

@@ -0,0 +1,16 @@
+name: "Mark Stale PRs"
+on:
+  schedule:
+    - cron: "30 20 * * *"
+
+permissions:
+  pull-requests: write
+
+jobs:
+  stale:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/stale@v4
+        with:
+          stale-pr-message: "This PR is stale. Please trigger a re-run of the PR check action."
+          days-before-stale: 7

bin/install.sh

@@ -1,4 +1,4 @@
-npm install &
-cd ./frontend && npm install &
-cd ./backend && npm install &
+npm ci &
+cd ./frontend && npm ci &
+cd ./backend && npm ci &
 wait

frontend/gulpfile.js

@@ -11,11 +11,9 @@ const { webpack } = require("webpack");
 const webpackDevConfig = require("./webpack.config.js");
 const webpackProdConfig = require("./webpack-production.config.js");
 const ts = require("gulp-typescript");
-// sass.compiler = require("dart-sass");
 
-let eslintConfig = "../.eslintrc.json";
-let tsProject = ts.createProject("tsconfig.json");
-// console.log(tsProject.src())
+const eslintConfig = "../.eslintrc.json";
+const tsProject = ts.createProject("tsconfig.json");
 
 task("clean", function () {
   return src(["./public/"], { allowEmpty: true }).pipe(vinylPaths(del));
@@ -117,16 +115,7 @@ task("updateSwCacheName", function () {
 
 task(
   "compile",
-  series(
-    "lint",
-    "lint-json",
-    // "copy-src-contents",
-    // "transpile-ts",
-    "webpack",
-    "static",
-    "sass",
-    "updateSwCacheName"
-  )
+  series("lint", "lint-json", "webpack", "static", "sass", "updateSwCacheName")
 );
 
 task(
@@ -134,8 +123,6 @@ task(
   series(
     "lint",
     "lint-json",
-    // "copy-src-contents",
-    // "transpile-ts",
     "webpack-production",
     "static",
     "sass",
@@ -147,12 +134,7 @@ task("watch", function () {
   watch("./src/styles/**/*.scss", series("sass"));
   watch(
     ["./src/scripts/**/*.js", "./src/scripts/**/*.ts"],
-    series(
-      "lint",
-      // "copy-src-contents",
-      // "transpile-ts",
-      "webpack"
-    )
+    series("lint", "webpack")
   );
   watch("./static/**/*.*", series("lint-json", "static"));
 });

frontend/package.json

@@ -4,8 +4,10 @@
   "license": "GPL-3.0",
   "private": true,
   "scripts": {
+    "dep-graph": "madge -c -i \"dep-graph.png\" ./src/scripts",
     "build": "npx gulp build",
     "build:live": "npx gulp build-production",
+    "build:webpack": "webpack --config webpack.config.js",
     "start:dev": "npm run build && concurrently --kill-others \"npx gulp watch\" \"firebase serve --only hosting\"",
     "deploy:live": "npm run build:live && firebase deploy -P live --only hosting"
   },
@@ -19,7 +21,7 @@
     "@babel/preset-env": "^7.16.11",
     "babel-loader": "^8.2.3",
     "buffer": "^6.0.3",
-    "circular-dependency-plugin": "^5.2.2",
+    "circular-dependency-plugin": "5.2.2",
     "dart-sass": "^1.25.0",
     "del": "^6.0.0",
     "eslint-webpack-plugin": "^3.1.1",
@@ -28,6 +30,7 @@
     "gulp-eslint-new": "^1.3.0",
     "gulp-sass": "^5.0.0",
     "gulp-typescript": "^6.0.0-alpha.1",
+    "madge": "5.0.1",
     "moment": "^2.29.1",
     "stream-browserify": "^3.0.0",
     "through2": "^4.0.2",
@@ -36,7 +39,8 @@
     "typescript": "^4.5.5",
     "vinyl-buffer": "^1.0.1",
     "vinyl-paths": "^3.0.1",
-    "webpack": "^5.68.0"
+    "webpack": "^5.68.0",
+    "webpack-cli": "4.9.2"
   },
   "dependencies": {
     "axios": "^0.21.2",

frontend/webpack-production.config.js

@@ -5,7 +5,7 @@ let circularImportNum = 0;
 
 module.exports = {
   mode: "production",
-  entry: path.resolve(__dirname, "src/srcipts/index.js"),
+  entry: path.resolve(__dirname, "src/scripts/index.js"),
   resolve: {
     fallback: {
       crypto: require.resolve("crypto-browserify"),

package.json

@@ -11,9 +11,7 @@
     "install:all": "sh ./bin/install.sh",
     "lint": "./node_modules/.bin/eslint './backend/**/*.js' './frontend/src/scripts/**/*.js'",
     "build:live": "cd ./frontend && npm run build:live",
-    "pretty": "prettier --check './backend/**/*.js' './frontend/src/**/*.{js,scss}' './frontend/static/**/*.{json,html}'",
-    "webpack": "cd frontend && npx webpack --config webpack.config.js",
-    "dep-graph": "madge -c -i \"dep-graph.png\" ./frontend/src/js"
+    "pretty": "prettier --check './backend/**/*.js' './frontend/src/**/*.{js,scss}' './frontend/static/**/*.{json,html}'"
   },
   "engines": {
     "npm": "8.1.2"
@@ -24,7 +22,6 @@
     "@typescript-eslint/eslint-plugin": "^5.11.0",
     "@typescript-eslint/parser": "^5.11.0",
     "babel-loader": "^8.2.3",
-    "circular-dependency-plugin": "^5.2.2",
     "concurrently": "5.3.0",
     "eslint": "8.8.0",
     "eslint-config-standard": "16.0.3",
@@ -34,11 +31,9 @@
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-promise": "5.1.0",
     "eslint-plugin-require-path-exists": "1.1.9",
-    "gulp-typescript": "^6.0.0-alpha.1",
     "husky": "4.3.0",
     "prettier": "2.1.2",
-    "pretty-quick": "3.1.0",
-    "webpack-cli": "^4.9.2"
+    "pretty-quick": "3.1.0"
   },
   "husky": {
     "hooks": {