monkeytypegame/monkeytype
1
1
Fork 0
mirror of https://github.com/monkeytypegame/monkeytype.git synced 2025-11-17 14:19:40 +08:00
Code Issues Projects Releases Packages Wiki Activity

properly handling errors in responses, disabled leaderboards

Browse source
This commit is contained in:
Miodec 2021-08-17 18:24:21 +01:00
parent 322b2ea9f3
commit ed5dace7b4
3 changed files with 19 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
backend/api/controllers/result.js
View file

@ -196,9 +196,12 @@ class ResultController {
static async getLeaderboard(req, res, next) {
try {
const { type, mode, mode2 } = req.params;
const results = await ResultDAO.getLeaderboard(type, mode, mode2);
return res.status(200).json(results);
// const { type, mode, mode2 } = req.params;
// const results = await ResultDAO.getLeaderboard(type, mode, mode2);
// return res.status(200).json(results);
return res
.status(503)
.json({ message: "Leaderboard temporarily disabled" });
} catch (e) {
next(e);
}
@ -206,10 +209,13 @@ class ResultController {
static async checkLeaderboardQualification(req, res, next) {
try {
const { uid } = req.decodedToken;
const { result } = req.body;
const data = await ResultDAO.checkLeaderboardQualification(uid, result);
return res.status(200).json(data);
// const { uid } = req.decodedToken;
// const { result } = req.body;
// const data = await ResultDAO.checkLeaderboardQualification(uid, result);
// return res.status(200).json(data);
return res
.status(503)
.json({ message: "Leaderboard temporarily disabled" });
} catch (e) {
next(e);
}

4
src/js/elements/leaderboards.js
View file

@ -237,7 +237,9 @@ function update() {
})
.catch((e) => {
Loader.hide();
Notifications.add("Something went wrong: " + e.message, -1);
let msg = e?.response?.data?.message ?? e.message;
Notifications.add("Failed to load leaderboards: " + msg, -1);
return;
});
}

4
src/js/test/test-leaderboards.js
View file

@ -187,7 +187,9 @@ export async function check(completedEvent) {
})
.catch((e) => {
$("#result .stats .leaderboards").addClass("hidden");
Notifications.add(e, -1);
let msg = e?.response?.data?.message ?? e.message;
Notifications.add("Failed to access leaderboard: " + msg, -1);
return;
});
}
} catch (e) {