From fb1ea6c8be84bd84c35b57379b5e2287c4c1790e Mon Sep 17 00:00:00 2001 From: Miodec Date: Thu, 30 Nov 2023 14:22:23 +0000 Subject: [PATCH] refactor: use for instead of forEach --- backend/src/dal/leaderboards.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/backend/src/dal/leaderboards.ts b/backend/src/dal/leaderboards.ts index 1e92ab48e..c05c5f625 100644 --- a/backend/src/dal/leaderboards.ts +++ b/backend/src/dal/leaderboards.ts @@ -145,7 +145,8 @@ export async function update( const start2 = performance.now(); let retval: number | undefined = undefined; - lb.forEach((lbEntry, index) => { + for (let index = 0; index < lb.length; index++) { + const lbEntry = lb[index]; lbEntry.rank = index + 1; if (uid && lbEntry.uid === uid) { retval = index + 1; @@ -159,7 +160,7 @@ export async function update( } delete lbEntry.badges; } - }); + } const end2 = performance.now(); const start3 = performance.now(); leaderboardUpdating[`${language}_${mode}_${mode2}`] = true;