monkeytypegame/monkeytype
1
1
Fork 0
mirror of https://github.com/monkeytypegame/monkeytype.git synced 2024-11-11 01:15:49 +08:00
Code Issues Projects Releases Packages Wiki Activity

fixed double invalid notification. closes #2285

Browse source
This commit is contained in:
Miodec 2022-01-11 20:01:56 +01:00
parent cd633d5e33
commit fc1aff8318
1 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/js/test/test-logic.js
View file

@ -1657,20 +1657,13 @@ export async function finish(difficultyFailed = false) {
Notifications.add("Test invalid - too short", 0);
tooShort = true;
dontSave = true;
}
if (
completedEvent.wpm < 0 ||
completedEvent.wpm > 350 ||
completedEvent.acc < 75 ||
completedEvent.acc > 100
) {
Notifications.add("Test invalid", 0);
} else if (completedEvent.wpm < 0 || completedEvent.wpm > 350) {
Notifications.add("Test invalid - wpm", 0);
TestStats.setInvalid();
dontSave = true;
} else if (completedEvent.acc < 75 || completedEvent.acc > 100) {
Notifications.add("Test invalid - accuracy", 0);
TestStats.setInvalid();
try {
firebase.analytics().logEvent("testCompletedInvalid", completedEvent);
} catch (e) {
console.log("Analytics unavailable");
}
dontSave = true;
}
@ -1706,7 +1699,14 @@ export async function finish(difficultyFailed = false) {
randomQuote
);
if (dontSave) return;
if (dontSave) {
try {
firebase.analytics().logEvent("testCompletedInvalid", completedEvent);
} catch (e) {
console.log("Analytics unavailable");
}
return;
}
// user is logged in