- main linting is now done by oxlint. eslint remains for linting json
files in the frontend (until oxlint adds support)
- move type checking to the lint step (with --type-check)
this improves performance by removing a duplicated typescript parse task
(instead of parsing for linting then again for type checking, it parses
once for both)
- add a `lint-fast` npm script to get some fast fail behavior. it simply
lints with no type information
- oxc plugins are still in preview, so the custom plugin that checks for
`__testing` usage outside of tests runs outside the main linting job
until performance is improved
- fixes some type issues (and config issues) that were not visible due
to a missing type check on some files. now type checking will run on
every file that is linted
- split up oxc config for easier management
waiting https://github.com/oxc-project/tsgolint/pull/494
seeing around 3x improvement in type aware linting
- **build: replace dotenv with vite env variables (@fehmer)**
- **build: combine vite config into a single file (@fehmer)**
---------
Co-authored-by: Miodec <jack@monkeytype.com>
When build fails for some reason the generate version step also failed
because the `/dist` directory is missing. This was hiding other problems
like an error in the fontawesome step.
Also changes the trigger for the frontend build to include `html` files.
revert fixing major version only of the
`PauMAVA/add-remove-label-action` action from #6344 because this action
does not have a `v1` tag
Co-authored-by: Christian Fehmer <fehmer@users.noreply.github.com>
### Description
1. remove duplicate correct examples in semantic-pr-title error message,
and make the examples more diverse (show how to credit multiple
contributors).
2. make the scope (quotes, languages, ...) consistently plural across
the repo docs (A subjective change I know, but in the changelog, the
scope looks better when it is plural i.e. **quotes:** add various
quotes).
3. update deprecated action `upload-artifact` from v3 to v4, because it
was making the `ci-failure-comment` workflow fail.
> Error: This request has been automatically failed because it uses a
deprecated version of `actions/upload-artifact: v3`. Learn more:
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
4. use the same official action to download and upload artifacts across
the repo's workflows.
5. add 'waiting for update' and remove 'waiting for review' labels when
the Monkey CI workflow fails.
6. fix actions' major version only, to allow minor updates and patches.
* chore(PR labeler): fix workflow having read access only when triggered from forks (@NadAlaba)
* remove logging and add an example with scope
* use action instead of gh cli for security
* use action to read json (instead of echoing contents in shell) for security
* step.if needs the same variables
* don't let attacker choose the labels
* step.name starts in caps
* no need for variable if it's used once
