From f8c729cd334772f5851c7703035e289fa1580957 Mon Sep 17 00:00:00 2001 From: deajan Date: Thu, 26 Jun 2025 13:56:27 +0200 Subject: [PATCH] kvm_qemu: Don't create snapshots for offline VMs --- examples/kvm-qemu/cube-backup.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/examples/kvm-qemu/cube-backup.sh b/examples/kvm-qemu/cube-backup.sh index a28f5fc..1b7a8f7 100644 --- a/examples/kvm-qemu/cube-backup.sh +++ b/examples/kvm-qemu/cube-backup.sh @@ -1,6 +1,6 @@ #!/usr/bin/env bash -# Script ver 2025042801 +# Script ver 2025062501 #TODO: blockcommit removes current snapshots, even if not done by cube # - it's interesting to make housekeeping, let's make this an option @@ -68,6 +68,12 @@ function create_snapshot { # Add VM xml description from virsh ## At least use a umask + if [ "$(virsh domstate $vm)" == "shut off" ]; then + log "Domain is not running, no need for snapshots" + return + fi + + # Don't redirect direct virsh output or SELinux may complain that we cannot write with virsh context xml=$(virsh dumpxml --security-info $vm || log "Failed to create XML file" "ERROR") echo "${xml}" > "${ROOT_DIR}/${vm}.xml"