From 438a8547b4dc982690d96e66c1a90d342308c454 Mon Sep 17 00:00:00 2001 From: ManOki Date: Thu, 12 Jan 2023 20:16:02 +0100 Subject: [PATCH 1/4] redis: add hint to wiki if overcommit disabled Signed-off-by: ManOki --- Containers/redis/start.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Containers/redis/start.sh b/Containers/redis/start.sh index 601d736a..53284bf9 100644 --- a/Containers/redis/start.sh +++ b/Containers/redis/start.sh @@ -1,5 +1,11 @@ #!/bin/bash +# Show wiki if vm.overcommit is disabled +if [[ $(sysctl -n vm.overcommit_memory) != "1" ]]; then + echo Memory overcommit is disabled but necessary for safe operation + echo See https://github.com/nextcloud/all-in-one/discussions/1731 how to enable overcommit +fi + # Run redis with a password if provided if [ -n "$REDIS_HOST_PASSWORD" ]; then exec redis-server --requirepass "$REDIS_HOST_PASSWORD" From af165ea5040ac7005d48fb53aff537405df493eb Mon Sep 17 00:00:00 2001 From: ManOki Date: Thu, 12 Jan 2023 20:32:40 +0100 Subject: [PATCH 2/4] Update Containers/redis/start.sh, add quotes Co-authored-by: Zoey Signed-off-by: ManOki --- Containers/redis/start.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Containers/redis/start.sh b/Containers/redis/start.sh index 53284bf9..a5446ce3 100644 --- a/Containers/redis/start.sh +++ b/Containers/redis/start.sh @@ -1,7 +1,7 @@ #!/bin/bash # Show wiki if vm.overcommit is disabled -if [[ $(sysctl -n vm.overcommit_memory) != "1" ]]; then +if [ "$(sysctl -n vm.overcommit_memory)" != "1" ]; then echo Memory overcommit is disabled but necessary for safe operation echo See https://github.com/nextcloud/all-in-one/discussions/1731 how to enable overcommit fi From 0ca8a8bfbc5f8a3791225c46719dbbb651703b44 Mon Sep 17 00:00:00 2001 From: ManOki Date: Thu, 12 Jan 2023 20:32:47 +0100 Subject: [PATCH 3/4] Update Containers/redis/start.sh, add quotes Co-authored-by: Zoey Signed-off-by: ManOki --- Containers/redis/start.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Containers/redis/start.sh b/Containers/redis/start.sh index a5446ce3..3ecbe2a0 100644 --- a/Containers/redis/start.sh +++ b/Containers/redis/start.sh @@ -2,7 +2,7 @@ # Show wiki if vm.overcommit is disabled if [ "$(sysctl -n vm.overcommit_memory)" != "1" ]; then - echo Memory overcommit is disabled but necessary for safe operation + echo "Memory overcommit is disabled but necessary for safe operation" echo See https://github.com/nextcloud/all-in-one/discussions/1731 how to enable overcommit fi From f7cc065ac9abc5f618d9e62136e7eedf25577d3d Mon Sep 17 00:00:00 2001 From: ManOki Date: Thu, 12 Jan 2023 20:32:55 +0100 Subject: [PATCH 4/4] Update Containers/redis/start.sh, add quotes Co-authored-by: Zoey Signed-off-by: ManOki --- Containers/redis/start.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Containers/redis/start.sh b/Containers/redis/start.sh index 3ecbe2a0..22b0eaf3 100644 --- a/Containers/redis/start.sh +++ b/Containers/redis/start.sh @@ -3,7 +3,7 @@ # Show wiki if vm.overcommit is disabled if [ "$(sysctl -n vm.overcommit_memory)" != "1" ]; then echo "Memory overcommit is disabled but necessary for safe operation" - echo See https://github.com/nextcloud/all-in-one/discussions/1731 how to enable overcommit + echo "See https://github.com/nextcloud/all-in-one/discussions/1731 how to enable overcommit" fi # Run redis with a password if provided