diff --git a/lib/Controller/InternalController.php b/lib/Controller/InternalController.php index 738364b3..dbd5478d 100644 --- a/lib/Controller/InternalController.php +++ b/lib/Controller/InternalController.php @@ -21,7 +21,6 @@ use OCP\Notification\IManager; class InternalController extends ApiController { private $userId; - private $manager; public function __construct( $AppName, @@ -29,7 +28,7 @@ class InternalController extends ApiController { $UserId, private CredentialService $credentialService, private IConfig $config, - IManager $IManager, + private IManager $manager, private IAppManager $appManager, ) { parent::__construct( @@ -39,7 +38,6 @@ class InternalController extends ApiController { 'Authorization, Content-Type, Accept', 86400); $this->userId = $UserId; - $this->manager = $IManager; } /** diff --git a/lib/Controller/ShareController.php b/lib/Controller/ShareController.php index 72d6ce5a..2be3f00e 100644 --- a/lib/Controller/ShareController.php +++ b/lib/Controller/ShareController.php @@ -36,8 +36,6 @@ use OCP\Notification\IManager; class ShareController extends ApiController { private $userId; - private $settings; - private $manager; private $limit = 50; private $offset = 0; @@ -54,8 +52,8 @@ class ShareController extends ApiController { private CredentialService $credentialService, private NotificationService $notificationService, private FileService $fileService, - SettingsService $config, - IManager $IManager, + private SettingsService $settings, + private IManager $manager, ) { parent::__construct( $AppName, @@ -65,8 +63,6 @@ class ShareController extends ApiController { 86400); $this->userId = $UserId; - $this->settings = $config; - $this->manager = $IManager; } diff --git a/lib/Migration/ServerSideEncryption.php b/lib/Migration/ServerSideEncryption.php index 1732af55..c257b851 100644 --- a/lib/Migration/ServerSideEncryption.php +++ b/lib/Migration/ServerSideEncryption.php @@ -48,7 +48,8 @@ class ServerSideEncryption implements IRepairStep { private LoggerInterface $logger, private CredentialService $credentialService, private CredentialRevisionService $revisionService, - private FileService $fileService, IConfig $config, + private FileService $fileService, + IConfig $config, ) { $this->installedVersion = $config->getAppValue('passman', 'installed_version'); } diff --git a/lib/Service/NotificationService.php b/lib/Service/NotificationService.php index fe5f5c34..debbe2ca 100644 --- a/lib/Service/NotificationService.php +++ b/lib/Service/NotificationService.php @@ -28,14 +28,10 @@ use OCP\IURLGenerator; use OCP\Notification\IManager; class NotificationService { - - private IManager $manager; - public function __construct( - IManager $IManager, + private IManager $manager, private IURLGenerator $urlGenerator, ) { - $this->manager = $IManager; } function credentialExpiredNotification($credential) { diff --git a/lib/Service/ShareService.php b/lib/Service/ShareService.php index 711cbabe..09390249 100644 --- a/lib/Service/ShareService.php +++ b/lib/Service/ShareService.php @@ -38,18 +38,14 @@ use OCP\DB\IResult; use OCP\Notification\IManager; class ShareService { - private CredentialMapper $credential; - - public function __construct( - private SharingACLMapper $sharingACL, - private ShareRequestMapper $shareRequest, - CredentialMapper $credentials, + private SharingACLMapper $sharingACL, + private ShareRequestMapper $shareRequest, + private CredentialMapper $credential, private CredentialRevisionService $revisions, - private EncryptService $encryptService, - private IManager $IManager, + private EncryptService $encryptService, + private IManager $IManager, ) { - $this->credential = $credentials; } /**