nextcloud/passman
1
1
Fork 0
mirror of https://github.com/nextcloud/passman.git synced 2024-09-20 06:46:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix Postgres sharing issue #581

Browse source 
Signed-off-by: Florent F <florent.git@zeteo.me>
This commit is contained in:
Florent 2023-06-13 20:30:02 +02:00 committed by Florent F
parent 49edeaf9e2
commit 3cfb3bdf10
3 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/Db/ShareRequestMapper.php
View file

@ -74,15 +74,14 @@ class ShareRequestMapper extends QBMapper {
* @return Entity[]
* @throws Exception
*/
public function getRequestsByItemGuidGroupedByUser(string $item_guid) {
public function getRequestsByItemGuid(string $item_guid) {
if (strtolower($this->db->getDatabasePlatform()->getName()) === 'mysql') {
$this->db->executeQuery("SET sql_mode = '';");
}
$qb = $this->db->getQueryBuilder();
$qb->select('*')
->from(self::TABLE_NAME)
->where($qb->expr()->eq('item_guid', $qb->createNamedParameter($item_guid, IQueryBuilder::PARAM_STR)))
->groupBy('target_user_id');
->where($qb->expr()->eq('item_guid', $qb->createNamedParameter($item_guid, IQueryBuilder::PARAM_STR)));
return $this->findEntities($qb);
}

2
lib/Service/ShareService.php
View file

@ -290,7 +290,7 @@ class ShareService {
* @throws Exception
*/
public function getCredentialPendingAclList(string $item_guid) {
return $this->shareRequest->getRequestsByItemGuidGroupedByUser($item_guid);
return $this->shareRequest->getRequestsByItemGuid($item_guid);
}
/**

4
tests/unit/lib/Db/ShareRequestMapperTest.php
View file

@ -112,7 +112,7 @@ class ShareRequestMapperTest extends DatabaseHelperTest {
}
/**
* @covers ::getRequestsByItemGuidGroupedByUser
* @covers ::getRequestsByItemGuid
*/
public function testGetRequestsByItemGuidGroupedByUser() {
$dataset = $this->findInDataset(
@ -121,7 +121,7 @@ class ShareRequestMapperTest extends DatabaseHelperTest {
$this->dataset->getRow(0)['item_guid']
);
$result = $this->mapper->getRequestsByItemGuidGroupedByUser($dataset[0]['item_guid']);
$result = $this->mapper->getRequestsByItemGuid($dataset[0]['item_guid']);
$this->assertCount(count($dataset), $result);