From 3e050c9a15c4c8339580c5a09cced5eaf39c09b4 Mon Sep 17 00:00:00 2001 From: fnuesse Date: Fri, 28 Sep 2018 14:07:40 +0200 Subject: [PATCH 001/119] Updated Css Signed-off-by: fnuesse --- appinfo/info.xml | 4 ++-- css/app.css | 22 ++++++++++++++++------ templates/views/show_vault.html | 12 +++++++----- 3 files changed, 25 insertions(+), 13 deletions(-) diff --git a/appinfo/info.xml b/appinfo/info.xml index 6bdb634d..109754bc 100644 --- a/appinfo/info.xml +++ b/appinfo/info.xml @@ -42,8 +42,8 @@ For an demo of this app visit [https://demo.passman.cc](https://demo.passman.cc) pgsql mysql openssl - - + + diff --git a/css/app.css b/css/app.css index 4833647f..71e32af7 100644 --- a/css/app.css +++ b/css/app.css @@ -275,7 +275,8 @@ padding: 12px; font-weight: bold; text-align: center; - z-index: 800; + z-index: 18000; + visibility: hidden; /* TODO remove */ background-color: red; color: white; } .warning_bar .fa-times { @@ -386,8 +387,11 @@ @media screen and (min-width: 769px) and (max-width: 820px) { #app-content #app-content-wrapper .title { display: none; } } - #app-content #app-content-wrapper .actions.creatable { + #app-content #app-content-wrapper .breadcrumb { float: left; + } + #app-content #app-content-wrapper .actions.creatable { + float: right; overflow: hidden; } #app-content #app-content-wrapper .actions.creatable .bubble { position: relative; @@ -665,7 +669,7 @@ cursor: pointer; } #app-content #app-content-wrapper .app_sidebar.item_selected { height: 25%; - display: inline-block; } + display: inline-block; } #app-content #app-content-wrapper .app_sidebar .credential-data .row { margin-bottom: 11px; } #app-content #app-content-wrapper .app_sidebar .credential-data .tags { @@ -1004,7 +1008,9 @@ margin-right: 0 !important; } #app-content #app-content-wrapper #passman-controls { - border-bottom: 1px solid #c9c9c9; } + margin-top: 5px; + border-bottom: 1px solid #c9c9c9; +} #passman-controls { box-sizing: border-box; @@ -1027,8 +1033,12 @@ width: 100%; } } @media only screen and (min-width: 768px) { #app-navigation + #app-content #passman-controls { - left: 250px; - width: calc( 100% - 250px ) !important; } } + left: 300px; + width: calc( 100% - 300px ) !important; } + #passman-controls { + right: 0px; + width: 50%;} +} #passman-controls .button, #passman-controls, #passman-controls input[type='submit'], #passman-controls input[type='text'], #passman-controls input[type='password'], #passman-controls select { box-sizing: border-box; display: inline-block; diff --git a/templates/views/show_vault.html b/templates/views/show_vault.html index 6175deba..f801f819 100644 --- a/templates/views/show_vault.html +++ b/templates/views/show_vault.html @@ -11,10 +11,6 @@ -
- - + -
+
@@ -86,59 +86,62 @@
-
-

{{selectedCredential.label}}

- -
- -
- - - -
-
- - - - - - - - -
-
-
+
+

{{selectedCredential.label}}

+ + +
+ +
+ + + +
+
+ + + + + + + + +
+
+
+ + @@ -58,7 +57,7 @@ ng-click="createVault(vault_name, vault_key, vault_key2)" ng-disabled="vault_key_score.score < minimal_value_key_strength || vault_key !== vault_key2 || vault_key === ''"> {{ 'new.vault.create' | translate }} -
+
{{creating_keys}} From 677ae51b425bf3a2183fd7a18ddb051e22bf0a46 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20N=C3=BCsse?= Date: Sat, 29 Sep 2018 20:52:51 +0200 Subject: [PATCH 003/119] Moved Search from passman-controls to nextcloud-default-searchicon --- js/app/controllers/credential.js | 21 +++++++++++++++++++-- js/app/controllers/main.js | 14 ++------------ sass/credentials.scss | 5 ++++- templates/views/show_vault.html | 5 ++++- 4 files changed, 29 insertions(+), 16 deletions(-) diff --git a/js/app/controllers/credential.js b/js/app/controllers/credential.js index 303635f1..e6ffe575 100644 --- a/js/app/controllers/credential.js +++ b/js/app/controllers/credential.js @@ -33,8 +33,8 @@ */ angular.module('passmanApp') .controller('CredentialCtrl', ['$scope', 'VaultService', 'SettingsService', '$location', 'CredentialService', - '$rootScope', 'FileService', 'EncryptService', 'TagService', '$timeout', 'NotificationService', 'CacheService', 'ShareService', 'SharingACL', '$interval', '$filter', '$routeParams', '$sce', '$translate', - function ($scope, VaultService, SettingsService, $location, CredentialService, $rootScope, FileService, EncryptService, TagService, $timeout, NotificationService, CacheService, ShareService, SharingACL, $interval, $filter, $routeParams, $sce, $translate) { + '$rootScope', 'FileService', 'EncryptService', 'TagService', '$timeout', 'NotificationService', 'CacheService', 'ShareService', 'SharingACL', '$interval', '$filter', '$routeParams', '$sce', '$translate','$compile', + function ($scope, VaultService, SettingsService, $location, CredentialService, $rootScope, FileService, EncryptService, TagService, $timeout, NotificationService, CacheService, ShareService, SharingACL, $interval, $filter, $routeParams, $sce, $translate, $compile) { $scope.active_vault = VaultService.getActiveVault(); if (!SettingsService.getSetting('defaultVault') || !SettingsService.getSetting('defaultVaultPass')) { if (!$scope.active_vault) { @@ -326,6 +326,23 @@ }; + + //searchboxfix + var native_search = document.getElementById("searchbox"); + native_search.classList.remove('hidden'); + native_search.addEventListener('keypress', function (e) { + if(e.keyCode == 13){ + e.preventDefault(); + } + }); + + native_search.addEventListener('keyup', function (e) { + console.log("keyup"); + $scope.$apply(function () { + $scope.filterOptions.filterText=native_search.value; + }); + }); + $scope.filtered_credentials = []; $scope.$watch('[selectedtags, filterOptions, delete_time, active_vault.credentials]', function () { if (!$scope.active_vault) { diff --git a/js/app/controllers/main.js b/js/app/controllers/main.js index 29fa5d3e..bce529ca 100644 --- a/js/app/controllers/main.js +++ b/js/app/controllers/main.js @@ -31,21 +31,11 @@ * Controller of the passmanApp */ angular.module('passmanApp') + + .controller('MainCtrl', ['$scope', '$rootScope', '$location', 'SettingsService', '$window', '$interval', '$filter', function ($scope, $rootScope, $location, SettingsService, $window, $interval, $filter) { $scope.selectedVault = false; - - var native_search = document.getElementById("searchbox"); - var old_search = document.getElementById("searchBox"); - - native_search.classList.remove('hidden'); - native_search.classList.add('searchbox','ng-valid','ng-touched','ng-dirty','ng-valid-parse','ng-empty'); - native_search.setAttribute("ng-model","filterOptions.filterText"); - - native_search.addEventListener("change", function(){ - old_search.value=native_search.innerText; - }); - $scope.http_warning_hidden = true; if ($location.$$protocol === 'http' && $location.$$host !== 'localhost' && $location.$host !== '127.0.0.1') { $scope.using_http = true; diff --git a/sass/credentials.scss b/sass/credentials.scss index 4f471002..8b07a1ec 100644 --- a/sass/credentials.scss +++ b/sass/credentials.scss @@ -113,7 +113,10 @@ } .searchboxContainer { - display: inline-block; + + /*display: inline-block;*/ + visibility: hidden; + display: none; margin-right: 14px; float: right; .searchbox { diff --git a/templates/views/show_vault.html b/templates/views/show_vault.html index 88848688..30fbc62f 100644 --- a/templates/views/show_vault.html +++ b/templates/views/show_vault.html @@ -28,7 +28,10 @@
- + + + + +
From c7c54ad299b7228ce99b07fb383380b9c64b666b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20N=C3=BCsse?= Date: Sat, 29 Sep 2018 21:02:23 +0200 Subject: [PATCH 004/119] Fixed Missing Remove function for searchfield-reset-button MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Felix Nüsse --- js/app/controllers/credential.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/js/app/controllers/credential.js b/js/app/controllers/credential.js index e6ffe575..ab8a3d29 100644 --- a/js/app/controllers/credential.js +++ b/js/app/controllers/credential.js @@ -329,6 +329,12 @@ //searchboxfix var native_search = document.getElementById("searchbox"); + native_search.nextElementSibling.addEventListener('click', function (e) { + $scope.$apply(function () { + $scope.filterOptions.filterText=""; + }); + }); + native_search.classList.remove('hidden'); native_search.addEventListener('keypress', function (e) { if(e.keyCode == 13){ From 44276dfafd7ffd935233c076fb10d8c3e6f2c51a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20N=C3=BCsse?= Date: Sat, 29 Sep 2018 23:08:12 +0200 Subject: [PATCH 005/119] Updated Navigationbar to latest styleguide MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Felix Nüsse --- js/app/controllers/menu.js | 40 +++++++++++++++++++++++++++++++++++--- sass/admin.scss | 9 --------- sass/app.scss | 1 - sass/menu.scss | 24 ++++++++++++++++------- sass/partials/button.scss | 7 ------- templates/main.php | 38 +++++++++++++++++++++++------------- 6 files changed, 78 insertions(+), 41 deletions(-) diff --git a/js/app/controllers/menu.js b/js/app/controllers/menu.js index f892af38..31165cb7 100644 --- a/js/app/controllers/menu.js +++ b/js/app/controllers/menu.js @@ -77,8 +77,38 @@ $rootScope.$broadcast('selected_tags_updated', $scope.selectedTags); }, true); + $scope.tagSelected = function (tag) { + for (var i = 0; i < $scope.selectedTags.length; i++) { + if($scope.selectedTags[i].text === tag.text){ + return true; + } + } + return false; + }; + + $scope.removeTagFromSelected = function (tag) { + var where =-1; + for (var i = 0; i < $scope.selectedTags.length; i++) { + if($scope.selectedTags[i].text === tag.text){ + where=i; + } + } + if(where === -1){ + console.log("Cant remove selected Tag, Tag not present!"); + }else{ + + } + $scope.selectedTags.splice(where, 1); + }; + $scope.tagClicked = function (tag) { - $scope.selectedTags.push(tag); + //check if tag already selected + if(!$scope.tagSelected(tag)){ + $scope.selectedTags.push(tag); + }else{ + //console.log("Already selected Tag!"); + $scope.removeTagFromSelected(tag); + } }; $rootScope.$on('credentials_loaded', function () { @@ -91,10 +121,14 @@ if ($scope.selectedTags.length === 0) { return TagService.getTags(); } else { - return $scope.filtered_tags; + return TagService.getTags(); + //Always show all tags + //return $scope.filtered_tags; } }, function (tags) { - $scope.available_tags = tags; + //Always show all tags + //$scope.available_tags = tags; + $scope.available_tags = TagService.getTags(); }, true); $scope.toggleDeleteTime = function () { diff --git a/sass/admin.scss b/sass/admin.scss index 8bac6f46..2eae188d 100644 --- a/sass/admin.scss +++ b/sass/admin.scss @@ -12,13 +12,4 @@ #requests-table{ width: 100%; } - - - .link{ - color: rgb(0, 102, 255) !important; - cursor: pointer; - } - .link:hover{ - text-decoration: underline; - } } \ No newline at end of file diff --git a/sass/app.scss b/sass/app.scss index 6ec78345..92f66161 100644 --- a/sass/app.scss +++ b/sass/app.scss @@ -33,7 +33,6 @@ @import 'settings'; #app-settings-content:not(.ng-hide) { - height: 90px; display: inherit !important; padding: 0; transition: height 0.15s ease-out; diff --git a/sass/menu.scss b/sass/menu.scss index 9138c431..a0e952e8 100644 --- a/sass/menu.scss +++ b/sass/menu.scss @@ -23,41 +23,51 @@ .settings-container { div { padding-left: 15px; - + } + button { + width: 80%; + margin-left: 15px; + margin-right: 15px; } } #app-navigation > ul{ - padding-bottom: 80px; > li > a{ - padding-left: 12px !important; z-index: auto; } } .nav-trashbin { - position: fixed !important; - bottom: 44px; + //position: fixed !important; + //bottom: 44px; width: inherit !important; border-right: 1px solid #eee; a { &.active{ - border-left: 3px solid #0082c9; + #border-left: 3px solid #0082c9; } background-color: #fff !important; opacity: 1 !important; z-index: 140; - padding: 0 20px; + //padding: 0 20px; .fa { margin-right: 15px; } } } +//to remove old entry +#taginput{ + visibility: hidden; + display: none; +} + #app-navigation { li{ a.taginput{ + visibility: hidden; + display: none; opacity: 1; } a{ diff --git a/sass/partials/button.scss b/sass/partials/button.scss index 5275fc04..f819ef8f 100644 --- a/sass/partials/button.scss +++ b/sass/partials/button.scss @@ -36,11 +36,4 @@ .button-red:hover{ background: lighten(#ce3702, 2%); color: #fff; -} -.link{ - color: rgb(0, 102, 255) !important; - cursor: pointer; -} -.link:hover{ - text-decoration: underline; } \ No newline at end of file diff --git a/templates/main.php b/templates/main.php index 0e8c79c4..a85ccd66 100644 --- a/templates/main.php +++ b/templates/main.php @@ -125,7 +125,7 @@ style('passman', 'app');
-
From da4bd08878890d4393ee84dbf5a2531d318e2550 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20N=C3=BCsse?= Date: Sun, 30 Sep 2018 00:06:54 +0200 Subject: [PATCH 006/119] Fixed main password list width MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Felix Nüsse --- sass/credentials.scss | 21 ++++++++++++++++----- templates/main.php | 6 +++--- templates/views/show_vault.html | 2 +- 3 files changed, 20 insertions(+), 9 deletions(-) diff --git a/sass/credentials.scss b/sass/credentials.scss index 8b07a1ec..5e34879d 100644 --- a/sass/credentials.scss +++ b/sass/credentials.scss @@ -20,12 +20,24 @@ * */ +//override nc style to fix wrong offset +#content { + padding-top: 47px !important; // 45px but +2 because of borders +} + +#app-content{ + //width: calc(100% - 300px); + margin-left: 300px; + width: calc(100vw - 300px); +} + #app-content { overflow-x: hidden; - width: 100%; + //width: 100%; #app-content-wrapper { min-height: 95%; - width: 100%; + display: block; + //width: 100%; #passman-controls { text-align: center; &.sidebar-shown { @@ -144,10 +156,9 @@ @include border-bottom-radius(3px); } } + .credential-table { - /*width: 100%; - margin-top: 44px; - */ + width: calc(100vw - 300px); tr:hover { background-color: darken(#fff, 4%); } diff --git a/templates/main.php b/templates/main.php index a85ccd66..33014a47 100644 --- a/templates/main.php +++ b/templates/main.php @@ -177,9 +177,9 @@ style('passman', 'app');
-
-
-
+
+
+
diff --git a/templates/views/show_vault.html b/templates/views/show_vault.html index 30fbc62f..22ac9854 100644 --- a/templates/views/show_vault.html +++ b/templates/views/show_vault.html @@ -45,7 +45,7 @@
-
+
Date: Sun, 30 Sep 2018 00:21:05 +0200 Subject: [PATCH 007/119] Fixed main password list width with sidebar opened MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Felix Nüsse --- sass/credentials.scss | 12 +++++++----- templates/main.php | 6 +++--- templates/views/show_vault.html | 4 ++-- 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/sass/credentials.scss b/sass/credentials.scss index 5e34879d..61bffb97 100644 --- a/sass/credentials.scss +++ b/sass/credentials.scss @@ -25,14 +25,16 @@ padding-top: 47px !important; // 45px but +2 because of borders } -#app-content{ - //width: calc(100% - 300px); - margin-left: 300px; - width: calc(100vw - 300px); +//this fixes the scrollbars, because passman-contols are shown above the sidebar. +#app-sidebar{ + height: auto; } #app-content { + margin-left: 300px; + width: calc(100vw - 300px); overflow-x: hidden; + //width: 100%; #app-content-wrapper { min-height: 95%; @@ -41,7 +43,7 @@ #passman-controls { text-align: center; &.sidebar-shown { - padding-right: 27% !important; + //padding-right: 27% !important; .title { @media screen and (max-width: 765px) { display: none; diff --git a/templates/main.php b/templates/main.php index 33014a47..a85ccd66 100644 --- a/templates/main.php +++ b/templates/main.php @@ -177,9 +177,9 @@ style('passman', 'app'); -
-
-
+
+
+
diff --git a/templates/views/show_vault.html b/templates/views/show_vault.html index 22ac9854..a0b09442 100644 --- a/templates/views/show_vault.html +++ b/templates/views/show_vault.html @@ -45,7 +45,7 @@
-
+
-

{{selectedCredential.label}}

Date: Sun, 30 Sep 2018 00:43:11 +0200 Subject: [PATCH 008/119] Fixed main password list gridview MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Felix Nüsse --- sass/credentials.scss | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sass/credentials.scss b/sass/credentials.scss index 61bffb97..d0b75558 100644 --- a/sass/credentials.scss +++ b/sass/credentials.scss @@ -234,7 +234,9 @@ } .grid-view { - margin-top: 44px; + width: calc(100vw - 300px); + height: 100%; + //margin-top: 44px; display: flex; flex-wrap: wrap; .credential { From d5220573def869fab035d72d55659737d272346a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20N=C3=BCsse?= Date: Sun, 30 Sep 2018 00:48:46 +0200 Subject: [PATCH 009/119] Fixed Missing Sidebarseperator MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Felix Nüsse --- sass/credentials.scss | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sass/credentials.scss b/sass/credentials.scss index d0b75558..b87389cb 100644 --- a/sass/credentials.scss +++ b/sass/credentials.scss @@ -23,6 +23,7 @@ //override nc style to fix wrong offset #content { padding-top: 47px !important; // 45px but +2 because of borders + height: 100%; } //this fixes the scrollbars, because passman-contols are shown above the sidebar. @@ -39,7 +40,8 @@ #app-content-wrapper { min-height: 95%; display: block; - //width: 100%; + //hack for missing separatorbar when app-sidebar is opened + height: calc(100vh - 49px); #passman-controls { text-align: center; &.sidebar-shown { From 5a9450a374fa84fb61547fbe4b23d9b144ced2c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20N=C3=BCsse?= Date: Sun, 30 Sep 2018 01:04:57 +0200 Subject: [PATCH 010/119] Centered Vaultlist MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Felix Nüsse --- sass/vaults.scss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sass/vaults.scss b/sass/vaults.scss index 4d7390c1..5a1d80b9 100644 --- a/sass/vaults.scss +++ b/sass/vaults.scss @@ -36,9 +36,9 @@ } } .vault_wrapper{ - margin: 0 auto; - margin-top: 20px; - width: 100%; + margin:0 auto auto auto; + transform: translate(-150px); + max-width: 420px; @include border-radius(5px); box-shadow: 0 1px 1px #777; From 0f634ef8204508c44d089afde7d5179490ede266 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20N=C3=BCsse?= Date: Sun, 30 Sep 2018 19:32:00 +0200 Subject: [PATCH 011/119] Fix credential-editing layout WIP MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Felix Nüsse --- sass/app.scss | 2 +- sass/credentials.scss | 13 +++++++------ sass/partials/tabs.scss | 19 +++++++++++++------ templates/views/edit_credential.html | 7 +++---- templates/views/partials/icon-picker.html | 4 +++- 5 files changed, 27 insertions(+), 18 deletions(-) diff --git a/sass/app.scss b/sass/app.scss index 92f66161..e41c491c 100644 --- a/sass/app.scss +++ b/sass/app.scss @@ -67,7 +67,7 @@ top: 45px; right: 0; left: 0; - + border-bottom: 1px solid #c9c9c9; padding: 0 !important; margin: 0; background-color: rgba(255, 255, 255, .95); diff --git a/sass/credentials.scss b/sass/credentials.scss index b87389cb..b5c3892e 100644 --- a/sass/credentials.scss +++ b/sass/credentials.scss @@ -573,21 +573,22 @@ @include border-left-radius(0) } .icon-picker { - float: left; + //float: left; margin-top: 3px; margin-left: -3px; - @include border-left-radius(3px); + //@include border-left-radius(3px); .cell { + //min-height: 44px; padding: 7px 12px 2px 12px; display: inline-block; font-size: 14px; border: 1px solid #ddd; background-color: lighten(#ddd, 5%); cursor: pointer; - @include border-left-radius(6px); - img { - height: 16px; - } + //@include border-left-radius(6px); + //img { + // height: 16px; + //} } .cell:hover { color: rgb(0, 102, 255); diff --git a/sass/partials/tabs.scss b/sass/partials/tabs.scss index d9e33964..7a5a0ca6 100644 --- a/sass/partials/tabs.scss +++ b/sass/partials/tabs.scss @@ -21,7 +21,9 @@ */ .tab_header { - margin: 44px 0 0; + width: calc(100vw - 300px); + // margin: 44px 0 0; + margin: 0 0 0; list-style: none; padding: 0; li.tab:first-child { @@ -45,9 +47,15 @@ display: none; } } + + li.inactive { + background-color: #fff !important; + color: unset !important; + } + li.active { - color: #fff; - position: relative; + + //position: relative; .indicator { display: inline-block; position: absolute; @@ -60,10 +68,9 @@ } .tab_container { - border: 1px solid; - border-color: #eee; + border: 1px solid #eee; border-top-color: #0082c9; - border-bottom: 0; + border-bottom-width: 0; clear: both; padding: 0 1em; } diff --git a/templates/views/edit_credential.html b/templates/views/edit_credential.html index 10ee9e7f..b03e8031 100644 --- a/templates/views/edit_credential.html +++ b/templates/views/edit_credential.html @@ -1,7 +1,6 @@
-
  • {{tab.title}}
    diff --git a/templates/views/partials/icon-picker.html b/templates/views/partials/icon-picker.html index 892244be..7de7b864 100644 --- a/templates/views/partials/icon-picker.html +++ b/templates/views/partials/icon-picker.html @@ -1,6 +1,8 @@
    - + + +
  • - - -
  • {{tag.text}}
  • @@ -143,11 +140,7 @@ style('passman', 'app'); {{ 'deleted.credentials' | translate }} - - - -
@@ -160,7 +153,7 @@ style('passman', 'app');
diff --git a/templates/views/settings.html b/templates/views/settings.html index 3c279f58..b9601cd5 100644 --- a/templates/views/settings.html +++ b/templates/views/settings.html @@ -1,29 +1,30 @@ - -
    -
  • {{tab.title}} -
    -
  • - -
- -
-
+ +
+
    +
  • {{tab.title | translate}} +
    +
  • +
+ +
+
+
+
\ No newline at end of file From 93e94d5c70c785bc4ee22d80de0f9e9614dbcf98 Mon Sep 17 00:00:00 2001 From: fnuesse Date: Sun, 30 Sep 2018 23:11:25 +0200 Subject: [PATCH 014/119] Changed + to New Signed-off-by: fnuesse --- templates/views/show_vault.html | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/templates/views/show_vault.html b/templates/views/show_vault.html index a0b09442..2a60a5ec 100644 --- a/templates/views/show_vault.html +++ b/templates/views/show_vault.html @@ -5,9 +5,12 @@
-
+
{{active_vault.name}}
+
+ {{ 'New' | translate}} +
@@ -26,13 +29,12 @@
-
+ + <!–normal nc add–> -
+
-->
Date: Sun, 30 Sep 2018 23:16:39 +0200 Subject: [PATCH 015/119] Tried to fix cursor Signed-off-by: fnuesse --- sass/credentials.scss | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sass/credentials.scss b/sass/credentials.scss index 6ad3e2ea..ad8aa282 100644 --- a/sass/credentials.scss +++ b/sass/credentials.scss @@ -171,7 +171,7 @@ background-color: #f8f8f8; } td { - cursor: pointer; + cursor: pointer !important; padding: 5px; border-bottom: 1px solid #eeeeee; .icon { @@ -189,7 +189,7 @@ opacity: 0.4; height: 20px; width: 32px; - cursor: pointer; + cursor: pointer !important; } .icon-more:hover { opacity: 1; @@ -252,7 +252,7 @@ padding: 2px; flex-direction: column; width: 100%; - cursor: pointer; + cursor: pointer !important; font-size: 1.75em; text-align: center; .label { @@ -381,7 +381,7 @@ font-size: 13px; width: 15%; i { - cursor: pointer; + cursor: pointer !important; } } td, th { @@ -590,7 +590,7 @@ font-size: 14px; border: 1px solid #ddd; background-color: lighten(#ddd, 5%); - cursor: pointer; + cursor: pointer !important; @include border-left-radius(6px); //img { // height: 16px; From 4489c7aa38a61f6038000b451c0953e0651ad2ea Mon Sep 17 00:00:00 2001 From: fnuesse Date: Sun, 30 Sep 2018 23:22:45 +0200 Subject: [PATCH 016/119] Fixed Trashbin not working Signed-off-by: fnuesse --- templates/main.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/main.php b/templates/main.php index 4bb3083b..604ce292 100644 --- a/templates/main.php +++ b/templates/main.php @@ -137,7 +137,7 @@ style('passman', 'app'); {{tag.text}} From 438da495837a06954ac9aecb55ee5993d16dfded Mon Sep 17 00:00:00 2001 From: fnuesse Date: Sun, 30 Sep 2018 23:25:51 +0200 Subject: [PATCH 017/119] Removed new entry from showing if trashbin is selected Signed-off-by: fnuesse --- templates/views/show_vault.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/views/show_vault.html b/templates/views/show_vault.html index 2a60a5ec..04dd8241 100644 --- a/templates/views/show_vault.html +++ b/templates/views/show_vault.html @@ -8,7 +8,7 @@
{{active_vault.name}}
-
+
{{ 'New' | translate}}
From a669c88493f92a65e0f254c99cee9df05c749568 Mon Sep 17 00:00:00 2001 From: fnuesse Date: Sun, 30 Sep 2018 23:37:10 +0200 Subject: [PATCH 018/119] Updated Buildtools Signed-off-by: fnuesse --- .travis.yml | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/.travis.yml b/.travis.yml index fe5c0511..595b9968 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,7 +1,9 @@ language: php php: - - 5.6 - 7 + - 7.0 + - 7.1 + - 7.2 env: global: - CORE_BRANCH=master @@ -83,17 +85,13 @@ addons: matrix: include: - - php: 5.6 - env: DB=sqlite;CLOUD=owncloud;SERVER_FOLDER=core - - php: 5.6 - env: DB=mysql;CLOUD=owncloud;SERVER_FOLDER=core - - php: 5.6 - env: DB=mysql;JSTESTS=1; - php: 7.0 env: DB=mysql; - php: 7.0 - env: DB=sqlite;CLOUD=owncloud;SERVER_FOLDER=core + env: DB=sqlite;CLOUD=nextcloud;SERVER_FOLDER=core - php: 7.0 - env: DB=mysql;CLOUD=owncloud;SERVER_FOLDER=core + env: DB=mysql;CLOUD=nextcloud;SERVER_FOLDER=core + - php: 7.0 + env: DB=mysql;JSTESTS=1; allow_failures: - env: DB=sqlite;CODECHECK=2 From d643b1bb806d52088255b898f037017201e5bb01 Mon Sep 17 00:00:00 2001 From: fnuesse Date: Sun, 30 Sep 2018 23:41:18 +0200 Subject: [PATCH 019/119] Updated info.xml Signed-off-by: fnuesse --- appinfo/info.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/appinfo/info.xml b/appinfo/info.xml index a08f4265..2e8a4f32 100644 --- a/appinfo/info.xml +++ b/appinfo/info.xml @@ -42,8 +42,8 @@ For an demo of this app visit [https://demo.passman.cc](https://demo.passman.cc) pgsql mysql openssl - - + + From 8dd47725e556794d3188c29fb35115b8597cbcb9 Mon Sep 17 00:00:00 2001 From: fnuesse Date: Sun, 30 Sep 2018 23:45:54 +0200 Subject: [PATCH 020/119] Increased max-version to 15 for nextcloud testing Signed-off-by: fnuesse --- appinfo/info.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/appinfo/info.xml b/appinfo/info.xml index 2e8a4f32..f5ee4e8d 100644 --- a/appinfo/info.xml +++ b/appinfo/info.xml @@ -42,8 +42,8 @@ For an demo of this app visit [https://demo.passman.cc](https://demo.passman.cc) pgsql mysql openssl - - + + From b03e975c48c06bec2cb4b3ec5ce00a4c426893be Mon Sep 17 00:00:00 2001 From: fnuesse Date: Mon, 1 Oct 2018 00:01:18 +0200 Subject: [PATCH 021/119] Switched test back to owncloud Signed-off-by: fnuesse --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 595b9968..b3d3a591 100644 --- a/.travis.yml +++ b/.travis.yml @@ -88,9 +88,9 @@ matrix: - php: 7.0 env: DB=mysql; - php: 7.0 - env: DB=sqlite;CLOUD=nextcloud;SERVER_FOLDER=core + env: DB=sqlite;CLOUD=owncloud;SERVER_FOLDER=core - php: 7.0 - env: DB=mysql;CLOUD=nextcloud;SERVER_FOLDER=core + env: DB=mysql;CLOUD=owncloud;SERVER_FOLDER=core - php: 7.0 env: DB=mysql;JSTESTS=1; allow_failures: From 2b22daeeceb9d6bb312e4051da1773e00654a45b Mon Sep 17 00:00:00 2001 From: fnuesse Date: Mon, 1 Oct 2018 00:02:52 +0200 Subject: [PATCH 022/119] Removed unsafe comparison in javascript Signed-off-by: fnuesse --- js/app/controllers/credential.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/app/controllers/credential.js b/js/app/controllers/credential.js index ab8a3d29..59bf7310 100644 --- a/js/app/controllers/credential.js +++ b/js/app/controllers/credential.js @@ -337,7 +337,7 @@ native_search.classList.remove('hidden'); native_search.addEventListener('keypress', function (e) { - if(e.keyCode == 13){ + if(e.keyCode === 13){ e.preventDefault(); } }); From 714d8768d926a1a4f4f8795a512289fca01f82dd Mon Sep 17 00:00:00 2001 From: fnuesse Date: Mon, 1 Oct 2018 00:11:53 +0200 Subject: [PATCH 023/119] removal of broken test Signed-off-by: fnuesse --- .travis.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index b3d3a591..c88efc17 100644 --- a/.travis.yml +++ b/.travis.yml @@ -87,10 +87,10 @@ matrix: include: - php: 7.0 env: DB=mysql; - - php: 7.0 - env: DB=sqlite;CLOUD=owncloud;SERVER_FOLDER=core - - php: 7.0 - env: DB=mysql;CLOUD=owncloud;SERVER_FOLDER=core +# - php: 7.0 +# env: DB=sqlite;CLOUD=owncloud;SERVER_FOLDER=core +# - php: 7.0 +# env: DB=mysql;CLOUD=owncloud;SERVER_FOLDER=core - php: 7.0 env: DB=mysql;JSTESTS=1; allow_failures: From b71970d9c9b5722a0a218e14afc8fc2fe96a7220 Mon Sep 17 00:00:00 2001 From: fnuesse Date: Mon, 1 Oct 2018 00:24:14 +0200 Subject: [PATCH 024/119] Removed unused parameter from credentialscontroller added nullcheck on native searchbox Signed-off-by: fnuesse --- js/app/controllers/credential.js | 40 +++++++++++++++++--------------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/js/app/controllers/credential.js b/js/app/controllers/credential.js index 59bf7310..181481f1 100644 --- a/js/app/controllers/credential.js +++ b/js/app/controllers/credential.js @@ -33,8 +33,8 @@ */ angular.module('passmanApp') .controller('CredentialCtrl', ['$scope', 'VaultService', 'SettingsService', '$location', 'CredentialService', - '$rootScope', 'FileService', 'EncryptService', 'TagService', '$timeout', 'NotificationService', 'CacheService', 'ShareService', 'SharingACL', '$interval', '$filter', '$routeParams', '$sce', '$translate','$compile', - function ($scope, VaultService, SettingsService, $location, CredentialService, $rootScope, FileService, EncryptService, TagService, $timeout, NotificationService, CacheService, ShareService, SharingACL, $interval, $filter, $routeParams, $sce, $translate, $compile) { + '$rootScope', 'FileService', 'EncryptService', 'TagService', '$timeout', 'NotificationService', 'CacheService', 'ShareService', 'SharingACL', '$interval', '$filter', '$routeParams', '$sce', '$translate', + function ($scope, VaultService, SettingsService, $location, CredentialService, $rootScope, FileService, EncryptService, TagService, $timeout, NotificationService, CacheService, ShareService, SharingACL, $interval, $filter, $routeParams, $sce, $translate) { $scope.active_vault = VaultService.getActiveVault(); if (!SettingsService.getSetting('defaultVault') || !SettingsService.getSetting('defaultVaultPass')) { if (!$scope.active_vault) { @@ -329,25 +329,27 @@ //searchboxfix var native_search = document.getElementById("searchbox"); - native_search.nextElementSibling.addEventListener('click', function (e) { - $scope.$apply(function () { - $scope.filterOptions.filterText=""; - }); - }); + if(native_search !== null){ + native_search.nextElementSibling.addEventListener('click', function (e) { + $scope.$apply(function () { + $scope.filterOptions.filterText=""; + }); + }); - native_search.classList.remove('hidden'); - native_search.addEventListener('keypress', function (e) { - if(e.keyCode === 13){ - e.preventDefault(); - } - }); + native_search.classList.remove('hidden'); + native_search.addEventListener('keypress', function (e) { + if(e.keyCode === 13){ + e.preventDefault(); + } + }); - native_search.addEventListener('keyup', function (e) { - console.log("keyup"); - $scope.$apply(function () { - $scope.filterOptions.filterText=native_search.value; - }); - }); + native_search.addEventListener('keyup', function (e) { + console.log("keyup"); + $scope.$apply(function () { + $scope.filterOptions.filterText=native_search.value; + }); + }); + } $scope.filtered_credentials = []; $scope.$watch('[selectedtags, filterOptions, delete_time, active_vault.credentials]', function () { From 2bd9dcf28e4de4e588ea47f59cc43ebb23a23c59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20N=C3=BCsse?= Date: Sat, 13 Oct 2018 12:45:52 +0200 Subject: [PATCH 025/119] Fixed wrong listlayout which added the sidebar as an overlay which scrolls with the list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Felix Nüsse --- sass/credentials.scss | 16 ++++++++++++++-- templates/views/show_vault.html | 3 +-- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/sass/credentials.scss b/sass/credentials.scss index ad8aa282..36aea562 100644 --- a/sass/credentials.scss +++ b/sass/credentials.scss @@ -24,6 +24,7 @@ #content { padding-top: 47px !important; // 45px but +2 because of borders height: 100%; + width: 100%; } //this fixes the scrollbars, because passman-contols are shown above the sidebar. @@ -39,7 +40,8 @@ //width: 100%; #app-content-wrapper { min-height: 95%; - display: block; + //display: block; + display:flex; //hack for missing separatorbar when app-sidebar is opened height: calc(100vh - 49px); #passman-controls { @@ -162,7 +164,7 @@ } .credential-table { - width: calc(100vw - 300px); + width: 100%; tr:hover { background-color: darken(#fff, 4%); } @@ -405,7 +407,17 @@ padding-right: 10px; } } + + .main_list{ + flex:1; + float:left; + height:auto; + overflow:auto; + width:100%; + } + .app_sidebar { + float:right; h2 { margin-bottom: 10px; font-weight: 400; diff --git a/templates/views/show_vault.html b/templates/views/show_vault.html index 04dd8241..e956f610 100644 --- a/templates/views/show_vault.html +++ b/templates/views/show_vault.html @@ -1,4 +1,4 @@ -
+
-
- {{active_vault.name}} + {{active_vault.name}}
- {{ 'New' | translate}} + {{ 'New' | translate}}
From 6060efe2ee1c99250f0323722f1092a11ec1e7c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20N=C3=BCsse?= Date: Sat, 13 Oct 2018 12:54:12 +0200 Subject: [PATCH 027/119] Added cursor:pointer to main_list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Felix Nüsse --- templates/views/show_vault.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/views/show_vault.html b/templates/views/show_vault.html index d73d5a48..60dded5f 100644 --- a/templates/views/show_vault.html +++ b/templates/views/show_vault.html @@ -67,7 +67,7 @@ - {{ ::credential.label}} + {{ ::credential.label}} From 4d079d2cbd35ee04b766782cb187a976170fdf68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20N=C3=BCsse?= Date: Sat, 13 Oct 2018 13:30:41 +0200 Subject: [PATCH 028/119] Udated Codestyle and cleaned files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Felix Nüsse --- css/app.css | 1 - js/app/controllers/main.js | 2 -- js/app/controllers/menu.js | 1 - sass/app.scss | 3 --- sass/credentials.scss | 3 --- templates/views/show_vault.html | 12 ------------ 6 files changed, 22 deletions(-) diff --git a/css/app.css b/css/app.css index cd574b01..d8374021 100644 --- a/css/app.css +++ b/css/app.css @@ -276,7 +276,6 @@ font-weight: bold; text-align: center; z-index: 18000; - visibility: hidden; /* TODO remove */ background-color: red; color: white; } .warning_bar .fa-times { diff --git a/js/app/controllers/main.js b/js/app/controllers/main.js index bce529ca..c122501c 100644 --- a/js/app/controllers/main.js +++ b/js/app/controllers/main.js @@ -31,8 +31,6 @@ * Controller of the passmanApp */ angular.module('passmanApp') - - .controller('MainCtrl', ['$scope', '$rootScope', '$location', 'SettingsService', '$window', '$interval', '$filter', function ($scope, $rootScope, $location, SettingsService, $window, $interval, $filter) { $scope.selectedVault = false; diff --git a/js/app/controllers/menu.js b/js/app/controllers/menu.js index 31165cb7..bb42f59e 100644 --- a/js/app/controllers/menu.js +++ b/js/app/controllers/menu.js @@ -23,7 +23,6 @@ (function () { 'use strict'; - /** * @ngdoc function * @name passmanApp.controller:MenuCtrl diff --git a/sass/app.scss b/sass/app.scss index e41c491c..df7025e2 100644 --- a/sass/app.scss +++ b/sass/app.scss @@ -53,14 +53,11 @@ } } - -// #app-content #app-content-wrapper #passman-controls { border-bottom: 1px solid #c9c9c9; margin-top: 5px; } - #passman-controls { box-sizing: border-box; position: fixed; diff --git a/sass/credentials.scss b/sass/credentials.scss index e74a94c8..f4514db5 100644 --- a/sass/credentials.scss +++ b/sass/credentials.scss @@ -604,9 +604,6 @@ background-color: lighten(#ddd, 5%); cursor: pointer; @include border-left-radius(6px); - //img { - // height: 16px; - //} } .cell:hover { color: rgb(0, 102, 255); diff --git a/templates/views/show_vault.html b/templates/views/show_vault.html index 60dded5f..cf711b1d 100644 --- a/templates/views/show_vault.html +++ b/templates/views/show_vault.html @@ -15,11 +15,6 @@
-
- -
From 073ee202ac4eafcd0a612a1aa946e1bea84c79c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20N=C3=BCsse?= Date: Sat, 13 Oct 2018 13:35:57 +0200 Subject: [PATCH 029/119] Added obstrusive highlighting in appnavigation (WIP) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Felix Nüsse --- sass/credentials.scss | 1 - sass/menu.scss | 3 +++ templates/main.php | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/sass/credentials.scss b/sass/credentials.scss index f4514db5..5b0241bb 100644 --- a/sass/credentials.scss +++ b/sass/credentials.scss @@ -611,7 +611,6 @@ } } - #iconPicker { .iconList { float: left; diff --git a/sass/menu.scss b/sass/menu.scss index a0e952e8..4896c5cb 100644 --- a/sass/menu.scss +++ b/sass/menu.scss @@ -65,6 +65,9 @@ #app-navigation { li{ + .highlight-selected{ + background-color: var(--color-primary); + } a.taginput{ visibility: hidden; display: none; diff --git a/templates/main.php b/templates/main.php index 604ce292..00ed6b46 100644 --- a/templates/main.php +++ b/templates/main.php @@ -134,7 +134,7 @@ style('passman', 'app');
  • - {{tag.text}} + {{tag.text}}
  • -
    -

    {{selectedCredential.label}}

    - +
    -
    - -
    + + +
    From ee55ca7119c0965f16424c559741362c1927581c Mon Sep 17 00:00:00 2001 From: fnuesse Date: Sun, 14 Oct 2018 00:46:52 +0200 Subject: [PATCH 032/119] Fix gridview-size --- sass/credentials.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sass/credentials.scss b/sass/credentials.scss index 7c4085e8..2c78ae04 100644 --- a/sass/credentials.scss +++ b/sass/credentials.scss @@ -259,7 +259,7 @@ } .grid-view { - width: calc(100vw - 300px); + width: 100%; height: 100%; //margin-top: 44px; display: flex; From 95d70771f2b102e10b0693c318caa71e8afdaf8b Mon Sep 17 00:00:00 2001 From: fnuesse Date: Sun, 14 Oct 2018 01:05:10 +0200 Subject: [PATCH 033/119] Updated Gridview to new design --- sass/credentials.scss | 12 +++++++++--- templates/views/show_vault.html | 12 +++++++++++- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/sass/credentials.scss b/sass/credentials.scss index 2c78ae04..284ec848 100644 --- a/sass/credentials.scss +++ b/sass/credentials.scss @@ -277,20 +277,26 @@ width: 100%; cursor: pointer; font-size: 1.75em; - text-align: center; + //text-align: center; .label { padding-top: 0.5em; - padding-left: 1em; + //padding-left: 1em; padding-right: 1em; line-height: 1.3em; word-wrap: break-word; + float: right; + } + .icon{ } .tags { - margin-bottom: 0.5em; + margin: 0 0 auto; + text-align: right; + //margin-bottom: 0.5em; .tag { color: #000 !important; margin-top: 5px; display: inline-block; + left:0; } } } diff --git a/templates/views/show_vault.html b/templates/views/show_vault.html index 959300ab..4b262b41 100644 --- a/templates/views/show_vault.html +++ b/templates/views/show_vault.html @@ -69,7 +69,17 @@ ng-click="selectCredential(credential)" use-theme type="'border-color'">
    -
    {{ ::credential.label}}
    +
    + + + + + + + + +
    {{ ::credential.label}}
    +
    From 201a070e19762d0097552e276b6824e14d3298ab Mon Sep 17 00:00:00 2001 From: fnuesse Date: Tue, 16 Oct 2018 19:48:59 +0200 Subject: [PATCH 035/119] Fixed Revisions --- templates/views/credential_revisions.html | 33 +++++++++++------------ templates/views/show_vault.html | 2 -- 2 files changed, 16 insertions(+), 19 deletions(-) diff --git a/templates/views/credential_revisions.html b/templates/views/credential_revisions.html index 6cea920f..f2d9f188 100644 --- a/templates/views/credential_revisions.html +++ b/templates/views/credential_revisions.html @@ -1,21 +1,19 @@ -
    {{ 'no.revisions' | translate}}
    +
    -
    @@ -237,4 +236,4 @@
    -
    + diff --git a/templates/views/show_vault.html b/templates/views/show_vault.html index 514d8c7d..772e7db3 100644 --- a/templates/views/show_vault.html +++ b/templates/views/show_vault.html @@ -90,8 +90,6 @@
    - -
    From 35b5a1487ffb2ce61c77f9dc84f15a59fd081902 Mon Sep 17 00:00:00 2001 From: fnuesse Date: Tue, 16 Oct 2018 19:56:22 +0200 Subject: [PATCH 036/119] Fixed Shares --- sass/credentials.scss | 3 +++ templates/views/credential_revisions.html | 2 +- templates/views/share_credential.html | 23 +++++++++++------------ 3 files changed, 15 insertions(+), 13 deletions(-) diff --git a/sass/credentials.scss b/sass/credentials.scss index 284ec848..b32aaea2 100644 --- a/sass/credentials.scss +++ b/sass/credentials.scss @@ -441,6 +441,9 @@ height:auto; overflow:auto; width:100%; + .share{ + overflow:hidden; + } } .app_sidebar { diff --git a/templates/views/credential_revisions.html b/templates/views/credential_revisions.html index f2d9f188..60cf41c3 100644 --- a/templates/views/credential_revisions.html +++ b/templates/views/credential_revisions.html @@ -1,4 +1,4 @@ -
    +