From c019a4ebe8c3d9483184f61873d401f4ba7ad9aa Mon Sep 17 00:00:00 2001 From: fnuesse Date: Sun, 16 Dec 2018 12:32:13 +0100 Subject: [PATCH] Improved performance by only getting the correct credential instead of full list Signed-off-by: fnuesse --- controller/credentialcontroller.php | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/controller/credentialcontroller.php b/controller/credentialcontroller.php index d18e7855..cb3a3265 100644 --- a/controller/credentialcontroller.php +++ b/controller/credentialcontroller.php @@ -105,17 +105,7 @@ class CredentialController extends ApiController { $link, $this->userId, Activity::TYPE_ITEM_ACTION); } - - //fetch the proper credentialelement, the returned element from createCredential is not usable in the frontend. - $credentials = $this->credentialService->getCredentialsByVaultId($vault_id, $this->userId); - foreach ($credentials as &$value) { - if($value->getGuid() == $credential->getGuid()){ - return new JSONResponse($value); - } - } - - //return old value as fallback - return new JSONResponse($credentials); + return new JSONResponse($this->credentialService->getCredentialByGUID($credential->getGuid())); } /** @@ -269,17 +259,7 @@ class CredentialController extends ApiController { $credential = $this->credentialService->updateCredential($credential); - - //fetch the proper credentialelement, the returned element from createCredential is not usable in the frontend. - $credentials = $this->credentialService->getCredentialsByVaultId($vault_id, $this->userId); - foreach ($credentials as &$value) { - if($value->getGuid() == $credential->getGuid()){ - return new JSONResponse($value); - } - } - - //return old value as fallback - return new JSONResponse($credential); + return new JSONResponse($this->credentialService->getCredentialByGUID($credential->getGuid())); } /**