nextcloud/passman
1
1
Fork 0
mirror of https://github.com/nextcloud/passman.git synced 2025-10-17 17:06:00 +08:00
Code Issues Projects Releases Packages Wiki Activity

add logging for failed file and credential deletion, assciated with the vault delete action

Browse source 
Signed-off-by: binsky <timo@binsky.org>
This commit is contained in:
binsky 2021-10-25 14:25:20 +02:00
parent d9815b3ca3
commit 935ff67d71
2 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
controller/filecontroller.php
View file

@ -77,6 +77,8 @@ class FileController extends ApiController {
try {
$this->fileService->deleteFile($file_id, $this->userId);
} catch (\Exception $e) {
$this->logger->error('Error deleting file (' . $file_id . ') in filecontroller:deleteFiles()',
['exception' => $e->getTrace(), 'message' => $e->getMessage()]);
continue;
}
}

17
controller/vaultcontroller.php
View file

@ -30,6 +30,7 @@ class VaultController extends ApiController {
private $credentialService;
private $settings;
private $fileService;
private $logger;
private $deleteVaultRequestService;
public function __construct($AppName,
@ -39,7 +40,8 @@ class VaultController extends ApiController {
CredentialService $credentialService,
DeleteVaultRequestService $deleteVaultRequestService,
SettingsService $settings,
FileService $fileService) {
FileService $fileService,
LoggerInterface $logger) {
parent::__construct(
$AppName,
$request,
@ -52,6 +54,7 @@ class VaultController extends ApiController {
$this->deleteVaultRequestService = $deleteVaultRequestService;
$this->settings = $settings;
$this->fileService = $fileService;
$this->logger = $logger;
}
/**
@ -174,14 +177,16 @@ class VaultController extends ApiController {
$credentials = $this->credentialService->getCredentialsByVaultId($vault->getId(), $this->userId);
foreach ($credentials as $credential) {
try {
// $credential = $this->credentialService->getCredentialByGUID($credential_guid, $this->userId);
if ($credential instanceof Credential) {
if ($credential instanceof Credential) {
try {
// $credential = $this->credentialService->getCredentialByGUID($credential_guid, $this->userId);
$this->credentialService->deleteCredentiaL($credential);
$this->credentialService->deleteCredentialParts($credential, $this->userId);
} catch (\Exception $e) {
$this->logger->error('Error deleting credential (' . $credential->getId() . ') in vaultcontroller:delete()',
['exception' => $e->getTrace(), 'message' => $e->getMessage()]);
continue;
}
} catch (\Exception $e) {
continue;
}
}
} catch (\Exception $e) {