From b89c03e84f61b3e6a2befc994a6d56c025aa5ae4 Mon Sep 17 00:00:00 2001
From: binsky <timo@binsky.org>
Date: Fri, 5 Apr 2024 22:10:01 +0200
Subject: [PATCH] mark credential notification as processed even if the
 corresponding credential does not exist #488

---
 lib/Controller/InternalController.php | 28 +++++++++++++++------------
 lib/Service/CredentialService.php     | 12 ++++++++++++
 lib/Service/NotificationService.php   |  8 ++++++++
 3 files changed, 36 insertions(+), 12 deletions(-)

diff --git a/lib/Controller/InternalController.php b/lib/Controller/InternalController.php
index f06f4939..6a761452 100644
--- a/lib/Controller/InternalController.php
+++ b/lib/Controller/InternalController.php
@@ -12,12 +12,13 @@
 namespace OCA\Passman\Controller;
 
 use OCA\Passman\Service\CredentialService;
+use OCA\Passman\Service\NotificationService;
 use OCP\App\IAppManager;
 use OCP\AppFramework\ApiController;
+use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\AppFramework\Http\JSONResponse;
 use OCP\IConfig;
 use OCP\IRequest;
-use OCP\Notification\IManager;
 
 class InternalController extends ApiController {
 	private $userId;
@@ -27,8 +28,8 @@ class InternalController extends ApiController {
 		IRequest $request,
 		$UserId,
 		private CredentialService $credentialService,
+		private NotificationService $notificationService,
 		private IConfig $config,
-		private IManager $manager,
 		private IAppManager $appManager,
 	) {
 		parent::__construct(
@@ -49,11 +50,7 @@ class InternalController extends ApiController {
 			$credential->setExpireTime(time() + (24 * 60 * 60));
 			$this->credentialService->upd($credential);
 
-			$notification = $this->manager->createNotification();
-			$notification->setApp('passman')
-				->setObject('credential', $credential_id)
-				->setUser($this->userId);
-			$this->manager->markProcessed($notification);
+			$this->notificationService->markNotificationOfCredentialAsProcessed($credential_id, $this->userId);
 		}
 	}
 
@@ -61,16 +58,23 @@ class InternalController extends ApiController {
 	 * @NoAdminRequired
 	 */
 	public function read($credential_id) {
+		try {
+			// need to check overall credential existence before, since getCredentialById() method call below throws a
+			// DoesNotExistException in two different cases, that we cannot differentiate in retrospect
+			$this->credentialService->credentialExistsById($credential_id);
+		} catch (DoesNotExistException) {
+			// got DoesNotExistException from CredentialMapper, means the credential does not even exist for any user,
+			// so we can also delete or mark the corresponding notification message as processed
+			$this->notificationService->markNotificationOfCredentialAsProcessed($credential_id, $this->userId);
+			return;
+		}
+
 		$credential = $this->credentialService->getCredentialById($credential_id, $this->userId);
 		if ($credential) {
 			$credential->setExpireTime(0);
 			$this->credentialService->upd($credential);
 
-			$notification = $this->manager->createNotification();
-			$notification->setApp('passman')
-				->setObject('credential', $credential_id)
-				->setUser($this->userId);
-			$this->manager->markProcessed($notification);
+			$this->notificationService->markNotificationOfCredentialAsProcessed($credential_id, $this->userId);
 		}
 	}
 
diff --git a/lib/Service/CredentialService.php b/lib/Service/CredentialService.php
index 6c50a492..fe66949e 100644
--- a/lib/Service/CredentialService.php
+++ b/lib/Service/CredentialService.php
@@ -193,6 +193,18 @@ class CredentialService {
 		}
 	}
 
+	/**
+	 * Check if a credential exists by id.
+	 *
+	 * @param int $credential_id
+	 * @return bool
+	 * @throws DoesNotExistException
+	 * @throws MultipleObjectsReturnedException
+	 */
+	public function credentialExistsById(int $credential_id): bool {
+		return $this->credentialMapper->getCredentialById($credential_id) !== null;
+	}
+
 	/**
 	 * Get credential label by credential id.
 	 *
diff --git a/lib/Service/NotificationService.php b/lib/Service/NotificationService.php
index 777d0693..02982b7a 100644
--- a/lib/Service/NotificationService.php
+++ b/lib/Service/NotificationService.php
@@ -120,4 +120,12 @@ class NotificationService {
 			->andWhere($qb->expr()->eq('object_type', 'credential'));
 		return $qb->execute();
 	}
+
+	function markNotificationOfCredentialAsProcessed(int $credential_id, string $user_id): void {
+		$notification = $this->manager->createNotification();
+		$notification->setApp('passman')
+			->setObject('credential', $credential_id)
+			->setUser($user_id);
+		$this->manager->markProcessed($notification);
+	}
 }