Use square bracket syntax to modify array

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
This commit is contained in:
Hamid Dehnavi 2023-07-06 11:02:16 +03:30
parent 2d6b08e57e
commit f6def6c811
5 changed files with 15 additions and 16 deletions

View file

@ -70,10 +70,10 @@ class AdminController extends ApiController {
$results = array(); $results = array();
$searchResult = $this->userManager->search($term); $searchResult = $this->userManager->search($term);
foreach ($searchResult as $user) { foreach ($searchResult as $user) {
array_push($results, array( $results[] = [
"value" => $user->getUID(), "value" => $user->getUID(),
"label" => $user->getDisplayName() . ' (' . $user->getBackendClassName() . ')', "label" => $user->getDisplayName() . ' (' . $user->getBackendClassName() . ')',
)); ];
} }
return new JSONResponse($results); return new JSONResponse($results);
} }
@ -125,7 +125,7 @@ class AdminController extends ApiController {
foreach($requests as $request){ foreach($requests as $request){
$r = $request->jsonSerialize(); $r = $request->jsonSerialize();
$r['displayName'] = Utils::getNameByUid($request->getRequestedBy(), $this->userManager); $r['displayName'] = Utils::getNameByUid($request->getRequestedBy(), $this->userManager);
array_push($results, $r); $results[] = $r;
} }
return new JSONResponse($results); return new JSONResponse($results);
} }

View file

@ -176,7 +176,7 @@ class ShareController extends ApiController {
$this->notificationService->credentialSharedNotification( $this->notificationService->credentialSharedNotification(
$notification $notification
); );
array_push($processed_users, $target_user); $processed_users[] = $target_user;
$this->activityService->add( $this->activityService->add(
'item_shared', [$credential->getLabel(), $target_user], 'item_shared', [$credential->getLabel(), $target_user],
@ -277,13 +277,12 @@ class ShareController extends ApiController {
$user_vaults = $this->vaultService->getByUser($user_id); $user_vaults = $this->vaultService->getByUser($user_id);
$result = array(); $result = array();
foreach ($user_vaults as $vault) { foreach ($user_vaults as $vault) {
array_push($result, $result[] = [
array( 'vault_id' => $vault->getId(),
'vault_id' => $vault->getId(), 'guid' => $vault->getGuid(),
'guid' => $vault->getGuid(), 'public_sharing_key' => $vault->getPublicSharingKey(),
'public_sharing_key' => $vault->getPublicSharingKey(), 'user_id' => $user_id,
'user_id' => $user_id, ];
));
} }
return new JSONResponse($result); return new JSONResponse($result);
} }
@ -332,7 +331,7 @@ class ShareController extends ApiController {
$result = $request->jsonSerialize(); $result = $request->jsonSerialize();
$c = $this->credentialService->getCredentialLabelById($request->getItemId()); $c = $this->credentialService->getCredentialLabelById($request->getItemId());
$result['credential_label'] = $c->getLabel(); $result['credential_label'] = $c->getLabel();
array_push($results, $result); $results[] = $result;
} }
return new JSONResponse($results); return new JSONResponse($results);
} catch (\Exception $ex) { } catch (\Exception $ex) {

View file

@ -71,7 +71,7 @@ class VaultController extends ApiController {
$credential = $this->credentialService->getRandomCredentialByVaultId($vault->getId(), $this->userId); $credential = $this->credentialService->getRandomCredentialByVaultId($vault->getId(), $this->userId);
$secret_field = $protected_credential_fields[array_rand($protected_credential_fields)]; $secret_field = $protected_credential_fields[array_rand($protected_credential_fields)];
if (isset($credential)) { if (isset($credential)) {
array_push($result, array( $result[] = [
'vault_id' => $vault->getId(), 'vault_id' => $vault->getId(),
'guid' => $vault->getGuid(), 'guid' => $vault->getGuid(),
'name' => $vault->getName(), 'name' => $vault->getName(),
@ -80,7 +80,7 @@ class VaultController extends ApiController {
'last_access' => $vault->getlastAccess(), 'last_access' => $vault->getlastAccess(),
'challenge_password' => $credential->{$secret_field}(), 'challenge_password' => $credential->{$secret_field}(),
'delete_request_pending' => ($this->deleteVaultRequestService->getDeleteRequestForVault($vault->getGuid())) ? true : false 'delete_request_pending' => ($this->deleteVaultRequestService->getDeleteRequestForVault($vault->getGuid())) ? true : false
)); ];
} }
} }
} }

View file

@ -124,7 +124,7 @@ class FileService {
$files = $this->fileMapper->getFileGuidsFromUser($userId); $files = $this->fileMapper->getFileGuidsFromUser($userId);
$results = array(); $results = array();
foreach ($files as $fileGuid) { foreach ($files as $fileGuid) {
array_push($results, $fileGuid->getGuid()); $results[] = $fileGuid->getGuid();
} }
return $results; return $results;
} }

View file

@ -90,7 +90,7 @@ class ShareService {
$t->setPermissions($permissions); $t->setPermissions($permissions);
$t->setCreated($created); $t->setCreated($created);
$t->setFromUserId($credential_owner); $t->setFromUserId($credential_owner);
array_push($requests, $this->shareRequest->createRequest($t)); $requests[] = $this->shareRequest->createRequest($t);
} }
return $requests; return $requests;
} }