mirror of
https://github.com/nodemailer/wildduck.git
synced 2026-01-22 17:31:44 +08:00
ea86c9fd46
* fix(pop3): ensure pipelined RETR commands complete before processing next command When POP3 clients use PIPELINING to send multiple RETR commands, the server must ensure each message is fully transmitted (including the terminating dot) before processing the next command. Previously, the server would call next() when the source stream ended, but the DataStream transform (which adds the terminating dot) might not have finished flushing to the socket yet. This caused race conditions where the +OK response for the next RETR command could be sent before the previous message's terminating dot, violating the POP3 protocol and causing clients like mpop to report "invalid reply" errors. The fix listens for the 'end' event on the DataStream (after it has written the terminating dot) rather than the source stream, ensuring proper sequencing of pipelined responses. * test(pop3): add pipelining tests for RETR command race condition fix Add comprehensive tests to verify that pipelined RETR commands are handled correctly without interleaving responses. These tests simulate aggressive POP3 client behavior (like mpop) that sends multiple RETR commands without waiting for individual responses. The tests verify: - Multiple pipelined RETR commands complete in order - Message terminating dot is sent before next +OK response - The fix code exists in connection.js - Rapid pipelining with 10 messages works correctly * chore(test): add POP3 tests to grunt proto task Update Gruntfile to include POP3 tests in the proto task, allowing protocol- level tests (IMAP unit + POP3) to run without requiring MongoDB/Redis. Changes: - Add mochaTest:pop3 configuration for POP3 tests - Add mochaTest:imap-unit for IMAP tests that don't require MongoDB - Update proto task to run both imap-unit and pop3 tests * fix(pop3): add defensive checks for stream.options.ttlcounter Add defensive checks in RETR and TOP commands to handle streams that don't have the options.ttlcounter property set. This fixes a TypeError crash in Forward Email and other implementations that don't set stream.options when returning from onFetchMessage. The fix checks if stream?.options?.ttlcounter is a function before calling it, and skips the ttlcounter call if not available. Also adds: - mpop pipelining tests for real-world client compatibility - Tests for streams without options property - Tests for streams with options but missing ttlcounter - CI configuration to install mpop for testing |
||
|---|---|---|
| .. | ||
| acme | ||
| api | ||
| attachments | ||
| handlers | ||
| lua | ||
| md5 | ||
| pop3 | ||
| schemas | ||
| tasks | ||
| attachment-storage.js | ||
| audit-handler.js | ||
| autoreply.js | ||
| bimi-handler.js | ||
| cert-handler.js | ||
| certs.js | ||
| consts.js | ||
| counters.js | ||
| data-url.js | ||
| db.js | ||
| dkim-handler.js | ||
| dkim-stream.js | ||
| elasticsearch.js | ||
| encrypt.js | ||
| ensure-es-index.js | ||
| errors.js | ||
| events.js | ||
| export.js | ||
| filehash-stream.js | ||
| filter-handler.js | ||
| forward.js | ||
| hashes.js | ||
| header-splitter.js | ||
| imap-notifier.js | ||
| limited-fetch.js | ||
| mailbox-handler.js | ||
| maildrop.js | ||
| maildropper.js | ||
| mbox-export.js | ||
| mbox-stream.js | ||
| message-handler.js | ||
| message-splitter.js | ||
| mongopaging-find-wrapper.js | ||
| newlines.js | ||
| plugins.js | ||
| prepare-search-filter.js | ||
| redis-url.js | ||
| roles.js | ||
| schemas.js | ||
| search-query.js | ||
| settings-handler.js | ||
| storage-handler.js | ||
| task-handler.js | ||
| tools.js | ||
| translations.js | ||
| user-cache.js | ||
| user-handler.js | ||