Result of query for services is used before handling possible error

This commit is contained in:
Frederik Ring 2024-04-15 14:04:58 +02:00 committed by GitHub
parent bf79c913e0
commit a5f6c0eca2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -151,15 +151,15 @@ func (s *script) stopContainersAndServices() (func() error, error) {
}),
Status: true,
})
if err != nil {
return noop, errwrap.Wrap(err, "error querying for services to scale down")
}
for _, s := range matchingServices {
servicesToScaleDown = append(servicesToScaleDown, handledSwarmService{
serviceID: s.ID,
initialReplicaCount: *s.Spec.Mode.Replicated.Replicas,
})
}
if err != nil {
return noop, errwrap.Wrap(err, "error querying for services to scale down")
}
}
if len(containersToStop) == 0 && len(servicesToScaleDown) == 0 {