offen/docker-volume-backup
1
1
Fork 0
mirror of https://github.com/offen/docker-volume-backup.git synced 2025-11-01 01:46:00 +08:00
Code Issues Projects Releases Packages Wiki Activity

do not use scanner to write file in chunks

Browse source
This commit is contained in:
Frederik Ring 2021-08-23 15:19:50 +02:00
parent f4f4fa9e74
commit ec87bd27e7
1 changed files with 2 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
cmd/backup/main.go
View file

@ -4,7 +4,6 @@
package main
import (
"bufio"
"bytes"
"context"
"errors"
@ -276,26 +275,11 @@ func (s *script) encryptBackup() error {
return fmt.Errorf("encryptBackup: error encrypting backup file: %w", err)
}
file, err := os.Open(s.file)
b, err := ioutil.ReadFile(s.file)
if err != nil {
return fmt.Errorf("encryptBackup: error opening unencrypted backup file: %w", err)
}
// backup files might be very large, so they are being read in chunks instead
// of loading them into memory once.
scanner := bufio.NewScanner(file)
chunk := make([]byte, 0, 1024*1024)
scanner.Buffer(chunk, 10*1024*1024)
for scanner.Scan() {
_, err = pt.Write(scanner.Bytes())
if err != nil {
file.Close()
pt.Close()
return fmt.Errorf("encryptBackup: error encrypting backup contents: %w", err)
}
}
file.Close()
pt.Write(b)
pt.Close()
gpgFile := fmt.Sprintf("%s.gpg", s.file)