ovh/the-bastion
1
1
Fork 0
mirror of https://github.com/ovh/the-bastion.git synced 2025-02-26 00:24:12 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix: osh-lingering-sessions-reaper.sh: tocttou on kill could terminate the script early

Browse source
This commit is contained in:
Stéphane Lesimple 2021-01-14 09:35:48 +00:00 committed by Stéphane Lesimple
parent e7e045a40d
commit 361c6a37a2
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
bin/cron/osh-lingering-sessions-reaper.sh
View file

@ -23,8 +23,9 @@ do
fi
done < <(ps -C ttyrec -o etimes,pid,tty --no-header)
if [ -n "$tokill" ]; then
# add || true to avoid script termination due to TOCTTOU and set -e
# shellcheck disable=SC2086
kill $tokill
kill $tokill || true
_log "Terminated $nb orphan ttyrec sessions (pids$tokill)"
fi
@ -41,8 +42,9 @@ do
fi
done < <(ps -C sshd --no-header -o etimes,pid,tty,user)
if [ -n "$tokill" ]; then
# add || true to avoid script termination due to TOCTTOU and set -e
# shellcheck disable=SC2086
kill $tokill
kill $tokill || true
_log "Terminated $nb orphan sshd sessions (pids$tokill)"
fi