ovh/the-bastion
1
1
Fork 0
mirror of https://github.com/ovh/the-bastion.git synced 2024-09-20 15:05:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: cleanup-guest-key-access: use cache for performance

Browse source
This commit is contained in:
Stéphane Lesimple 2022-07-06 12:41:28 +00:00 committed by Stéphane Lesimple
parent bdea34ccad
commit 7a3306a00d
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
bin/cron/osh-cleanup-guest-key-access.pl
View file

@ -106,10 +106,10 @@ foreach my $shortGroup (sort keys %$groups) {
# the "members" of the system group key$shortGroup might be either members or guests,
# so we first rule out members
next if OVH::Bastion::is_group_member(account => $account, group => $shortGroup);
next if OVH::Bastion::is_group_member(account => $account, group => $shortGroup, cache => 1);
# it seems to be a guest, double-check that
next if !OVH::Bastion::is_group_guest(account => $account, group => $shortGroup);
next if !OVH::Bastion::is_group_guest(account => $account, group => $shortGroup, cache => 1);
_log "<$shortGroup/$account> found a guest, checking remaining accesses..." if $verbose;
@ -138,7 +138,7 @@ foreach my $shortGroup (sort keys %$groups) {
_log "<$shortGroup/$account> The account is a guest of group but has no remaining access, cleaning up...";
# get $group from $shortGroup
$fnret = OVH::Bastion::is_valid_group_and_existing(group => $shortGroup, groupType => 'key');
$fnret = OVH::Bastion::is_valid_group_and_existing(group => $shortGroup, groupType => 'key', cache => 1);
if (!$fnret) {
_warn "<$shortGroup/$account> Group seems invalid ($fnret), skipping";
next;