2019-06-11 23:04:59 +08:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
|
|
require 'rails_helper'
|
|
|
|
|
|
2019-06-13 06:17:32 +08:00
|
|
|
describe ExternalProtocolsController, type: :controller do
|
2019-06-11 23:04:59 +08:00
|
|
|
login_user
|
|
|
|
|
|
|
|
|
|
let(:user) { subject.current_user }
|
|
|
|
|
let(:team) { create :team, created_by: user }
|
|
|
|
|
let!(:user_team) { create :user_team, :admin, user: user, team: team }
|
|
|
|
|
|
2019-06-13 14:49:03 +08:00
|
|
|
describe 'GET index' do
|
|
|
|
|
let(:params) do
|
|
|
|
|
{
|
|
|
|
|
team_id: team.id,
|
|
|
|
|
key: 'search_string',
|
|
|
|
|
protocol_source: 'protocolsio/v3',
|
2019-07-04 22:02:29 +08:00
|
|
|
page_id: 2,
|
|
|
|
|
page_size: 50,
|
2019-06-13 14:49:03 +08:00
|
|
|
order_field: 'activity',
|
|
|
|
|
order_dir: 'desc'
|
|
|
|
|
}
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
let(:action) { get :index, params: params }
|
|
|
|
|
|
2019-07-04 22:02:29 +08:00
|
|
|
let(:valid_search_response) do
|
|
|
|
|
{
|
|
|
|
|
protocols: [],
|
|
|
|
|
pagination: {
|
|
|
|
|
current_page: 2,
|
|
|
|
|
total_pages: 6,
|
|
|
|
|
page_size: 10
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
end
|
|
|
|
|
|
2019-06-14 16:41:51 +08:00
|
|
|
before do
|
|
|
|
|
service = double('success_service')
|
|
|
|
|
allow(service).to(receive(:succeed?)).and_return(true)
|
2019-07-04 22:02:29 +08:00
|
|
|
allow(service).to(receive(:protocols_list)).and_return(valid_search_response)
|
2019-06-14 16:41:51 +08:00
|
|
|
|
|
|
|
|
allow_any_instance_of(ProtocolImporters::SearchProtocolsService).to(receive(:call)).and_return(service)
|
|
|
|
|
end
|
|
|
|
|
|
2019-06-13 14:49:03 +08:00
|
|
|
it 'returns JSON, 200 response when protocol parsing was valid' do
|
|
|
|
|
action
|
|
|
|
|
expect(response).to have_http_status(:success)
|
2019-09-12 23:21:48 +08:00
|
|
|
expect(response.media_type).to eq 'application/json'
|
2019-06-13 14:49:03 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'contains html key in the response' do
|
|
|
|
|
action
|
|
|
|
|
expect(JSON.parse(response.body)).to have_key('html')
|
|
|
|
|
end
|
2019-07-04 22:02:29 +08:00
|
|
|
|
|
|
|
|
it 'contains page_id in the response' do
|
|
|
|
|
action
|
|
|
|
|
expect(JSON.parse(response.body)['page_id']).to eq 2
|
|
|
|
|
end
|
2019-06-13 14:49:03 +08:00
|
|
|
end
|
|
|
|
|
|
2019-06-13 17:17:08 +08:00
|
|
|
describe 'GET show' do
|
|
|
|
|
let(:params) do
|
|
|
|
|
{
|
|
|
|
|
team_id: team.id,
|
|
|
|
|
protocol_source: 'protocolsio/v3',
|
|
|
|
|
protocol_id: 'protocolsio_uri'
|
|
|
|
|
}
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
let(:action) { get :show, params: params }
|
|
|
|
|
|
2019-07-11 01:02:21 +08:00
|
|
|
let(:html_preview) { double('html_preview') }
|
|
|
|
|
|
|
|
|
|
before do
|
|
|
|
|
allow(html_preview).to(receive(:as_json).and_return('<html></html>'))
|
|
|
|
|
allow(html_preview).to(receive_message_chain(:request, :last_uri, :to_s).and_return('http://www.protocols.io/test_protocol'))
|
|
|
|
|
end
|
2019-06-13 17:17:08 +08:00
|
|
|
|
2019-07-11 01:02:21 +08:00
|
|
|
it 'returns JSON, 200 response when preview was successfully returned' do
|
2019-09-12 23:21:48 +08:00
|
|
|
allow_any_instance_of(ProtocolImporters::ProtocolsIo::V3::ApiClient)
|
2019-06-13 19:28:08 +08:00
|
|
|
.to(receive(:protocol_html_preview)).and_return(html_preview)
|
2019-06-13 17:17:08 +08:00
|
|
|
|
|
|
|
|
# Call action
|
|
|
|
|
action
|
|
|
|
|
expect(response).to have_http_status(:success)
|
2019-09-12 23:21:48 +08:00
|
|
|
expect(response.media_type).to eq 'application/json'
|
2019-06-13 17:17:08 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'should return html preview in the JSON' do
|
2019-09-12 23:21:48 +08:00
|
|
|
allow_any_instance_of(ProtocolImporters::ProtocolsIo::V3::ApiClient)
|
2019-06-13 19:28:08 +08:00
|
|
|
.to(receive(:protocol_html_preview)).and_return(html_preview)
|
2019-06-13 17:17:08 +08:00
|
|
|
|
|
|
|
|
# Call action
|
|
|
|
|
action
|
2019-07-11 01:02:21 +08:00
|
|
|
expect(JSON.parse(response.body)['html']).to eq('<html></html>')
|
2019-06-13 17:17:08 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'returns error JSON and 400 response when something went wrong' do
|
2019-09-12 23:21:48 +08:00
|
|
|
allow_any_instance_of(ProtocolImporters::ProtocolsIo::V3::ApiClient)
|
2019-06-13 19:28:08 +08:00
|
|
|
.to(receive(:protocol_html_preview)).and_raise(StandardError)
|
2019-06-13 17:17:08 +08:00
|
|
|
|
|
|
|
|
# Call action
|
|
|
|
|
action
|
|
|
|
|
expect(response).to have_http_status(:bad_request)
|
|
|
|
|
expect(JSON.parse(response.body)).to have_key('errors')
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2019-06-11 23:04:59 +08:00
|
|
|
describe 'GET new' do
|
|
|
|
|
let(:params) do
|
|
|
|
|
{
|
|
|
|
|
team_id: team.id,
|
|
|
|
|
protocol_source: 'protocolsio/v3',
|
|
|
|
|
page_id: 1,
|
|
|
|
|
page_size: 10,
|
|
|
|
|
order_field: 'activity',
|
|
|
|
|
order_dir: 'desc'
|
|
|
|
|
}
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
let(:action) { get :new, params: params }
|
|
|
|
|
|
2019-06-13 19:28:08 +08:00
|
|
|
context 'successful response' do
|
|
|
|
|
let(:protocol) { create :protocol }
|
2019-06-11 23:04:59 +08:00
|
|
|
|
2019-06-13 19:28:08 +08:00
|
|
|
before do
|
|
|
|
|
service = double('success_service')
|
|
|
|
|
allow(service).to(receive(:succeed?)).and_return(true)
|
|
|
|
|
allow(service).to(receive(:built_protocol)).and_return(protocol)
|
2019-06-27 19:10:28 +08:00
|
|
|
allow(service).to(receive(:serialized_steps)).and_return({}.to_s)
|
|
|
|
|
allow(service).to(receive(:steps_assets)).and_return([])
|
2019-06-11 23:04:59 +08:00
|
|
|
|
2019-06-13 19:28:08 +08:00
|
|
|
allow_any_instance_of(ProtocolImporters::BuildProtocolFromClientService)
|
|
|
|
|
.to(receive(:call)).and_return(service)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'returns JSON, 200 response when protocol parsing was valid' do
|
|
|
|
|
action
|
|
|
|
|
expect(response).to have_http_status(:success)
|
2019-09-12 23:21:48 +08:00
|
|
|
expect(response.media_type).to eq 'application/json'
|
2019-06-13 19:28:08 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'should return html form in the JSON' do
|
|
|
|
|
action
|
|
|
|
|
expect(JSON.parse(response.body)).to have_key('html')
|
|
|
|
|
end
|
2019-06-11 23:04:59 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'returns JSON, 400 response when protocol parsing was invalid' do
|
|
|
|
|
# Setup double
|
2019-06-13 19:28:08 +08:00
|
|
|
service = double('failed_service')
|
2019-06-11 23:04:59 +08:00
|
|
|
allow(service).to(receive(:succeed?)).and_return(false)
|
|
|
|
|
allow(service).to(receive(:errors)).and_return({})
|
|
|
|
|
|
2019-06-13 19:28:08 +08:00
|
|
|
allow_any_instance_of(ProtocolImporters::BuildProtocolFromClientService)
|
|
|
|
|
.to(receive(:call)).and_return(service)
|
2019-06-11 23:04:59 +08:00
|
|
|
|
|
|
|
|
# Call action
|
|
|
|
|
action
|
|
|
|
|
expect(response).to have_http_status(:bad_request)
|
2019-09-12 23:21:48 +08:00
|
|
|
expect(response.media_type).to eq 'application/json'
|
2019-06-11 23:04:59 +08:00
|
|
|
end
|
|
|
|
|
end
|
2019-06-13 07:02:44 +08:00
|
|
|
|
|
|
|
|
describe 'POST create' do
|
|
|
|
|
context 'when user has import permissions for the team' do
|
|
|
|
|
let(:params) do
|
|
|
|
|
{
|
|
|
|
|
team_id: team.id,
|
2019-06-27 19:10:28 +08:00
|
|
|
protocol: {
|
|
|
|
|
name: 'name',
|
|
|
|
|
steps: {}.to_s
|
|
|
|
|
}
|
2019-06-13 07:02:44 +08:00
|
|
|
}
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
let(:action) { post :create, params: params }
|
|
|
|
|
|
|
|
|
|
it 'returns JSON, 200 response when protocol parsing was valid' do
|
|
|
|
|
# Setup double
|
|
|
|
|
service = double('success_service')
|
|
|
|
|
allow(service).to(receive(:succeed?)).and_return(true)
|
2019-06-27 19:10:28 +08:00
|
|
|
allow(service).to(receive(:protocol)).and_return(create(:protocol))
|
2019-06-13 07:02:44 +08:00
|
|
|
|
|
|
|
|
allow_any_instance_of(ProtocolImporters::ImportProtocolService).to(receive(:call)).and_return(service)
|
|
|
|
|
|
|
|
|
|
# Call action
|
|
|
|
|
action
|
|
|
|
|
expect(response).to have_http_status(:success)
|
2019-09-12 23:21:48 +08:00
|
|
|
expect(response.media_type).to eq 'application/json'
|
2019-06-13 07:02:44 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'returns JSON, 400 response when protocol parsing was invalid' do
|
|
|
|
|
# Setup double
|
|
|
|
|
service = double('success_service')
|
|
|
|
|
allow(service).to(receive(:succeed?)).and_return(false)
|
|
|
|
|
allow(service).to(receive(:errors)).and_return({})
|
|
|
|
|
|
|
|
|
|
allow_any_instance_of(ProtocolImporters::ImportProtocolService).to(receive(:call)).and_return(service)
|
|
|
|
|
|
|
|
|
|
# Call action
|
|
|
|
|
action
|
|
|
|
|
expect(response).to have_http_status(:bad_request)
|
2019-09-12 23:21:48 +08:00
|
|
|
expect(response.media_type).to eq 'application/json'
|
2019-06-13 07:02:44 +08:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when user has no import permissions for the team' do
|
|
|
|
|
let(:user_two) { create :user }
|
|
|
|
|
let(:team_two) { create :team, created_by: user_two }
|
|
|
|
|
|
|
|
|
|
let(:params) do
|
|
|
|
|
{
|
|
|
|
|
team_id: team_two.id,
|
|
|
|
|
protocol_params: {},
|
|
|
|
|
steps_params: {}
|
|
|
|
|
}
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'returns 403 when trying to import to forbidden team' do
|
|
|
|
|
post :create, params: params
|
|
|
|
|
expect(response).to have_http_status(:forbidden)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
end
|
2019-06-11 23:04:59 +08:00
|
|
|
end
|
