From 652b9014e13ec330364651d1e6180232d25ae162 Mon Sep 17 00:00:00 2001 From: Miha Mencin Date: Mon, 20 Jan 2020 15:37:04 +0100 Subject: [PATCH 1/2] SCI-4270 update selector --- app/assets/javascripts/repositories/repository_datatable.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/repositories/repository_datatable.js b/app/assets/javascripts/repositories/repository_datatable.js index eaf0655ee..be6801518 100644 --- a/app/assets/javascripts/repositories/repository_datatable.js +++ b/app/assets/javascripts/repositories/repository_datatable.js @@ -14,6 +14,7 @@ var RepositoryDatatable = (function(global) { var TABLE_WRAPPER_ID = '.repository-table'; var TABLE = null; var EDITABLE = false; + var SELECT_ALL_SELECTOR = "#checkbox > input" var rowsSelected = []; @@ -125,7 +126,7 @@ var RepositoryDatatable = (function(global) { var $header = TABLE.table().header(); var $chkboxAll = $('.repository-row-selector', $table); var $chkboxChecked = $('.repository-row-selector:checked', $table); - var chkboxSelectAll = $('input[name="select_all"]', $header).get(0); + var chkboxSelectAll = $(SELECT_ALL_SELECTOR, $header).get(0); // If none of the checkboxes are checked if ($chkboxChecked.length === 0) { @@ -192,7 +193,7 @@ var RepositoryDatatable = (function(global) { }); // Handle click on "Select all" control - $('.dataTables_scrollHead input[name="select_all"]').change(function(ev) { + $(SELECT_ALL_SELECTOR).change(function(ev) { if (this.checked) { $('.repository-row-selector:not(:checked)').trigger('click'); } else { From ba4e06f7e61ac367249a7d6bf258d064174df7c0 Mon Sep 17 00:00:00 2001 From: Miha Mencin Date: Tue, 21 Jan 2020 09:01:39 +0100 Subject: [PATCH 2/2] make selector a bit more specific make selector more specific --- app/assets/javascripts/repositories/repository_datatable.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/javascripts/repositories/repository_datatable.js b/app/assets/javascripts/repositories/repository_datatable.js index be6801518..10be0e2bd 100644 --- a/app/assets/javascripts/repositories/repository_datatable.js +++ b/app/assets/javascripts/repositories/repository_datatable.js @@ -14,7 +14,7 @@ var RepositoryDatatable = (function(global) { var TABLE_WRAPPER_ID = '.repository-table'; var TABLE = null; var EDITABLE = false; - var SELECT_ALL_SELECTOR = "#checkbox > input" + var SELECT_ALL_SELECTOR = "#checkbox > input[name=select_all]" var rowsSelected = [];