scinote-eln/scinote-web
1
1
Fork 0
mirror of https://github.com/scinote-eln/scinote-web.git synced 2025-12-16 21:59:00 +08:00
Code Issues Projects Releases Packages Wiki Activity

Skip merging encrypted PDF files in report PDF generation [SCI-5791]

Browse source
This commit is contained in:
Martin Artnik 2021-06-08 14:01:37 +02:00
parent 44b4e13fa8
commit 08a5d1cfa5
1 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
app/jobs/reports/pdf_job.rb
View file

@ -6,6 +6,8 @@ module Reports
include InputSanitizeHelper include InputSanitizeHelper
include ReportsHelper include ReportsHelper
PDFUNITE_ENCRYPTED_PDF_ERROR_STRING = 'Unimplemented Feature: Could not merge encrypted files'
queue_as :reports queue_as :reports
discard_on StandardError do |job, error| discard_on StandardError do |job, error|
@ -119,12 +121,22 @@ module Reports
def merge_pdf_files(file, report_file) def merge_pdf_files(file, report_file)
merged_file = Tempfile.new(['report', '.pdf'], binmode: true) merged_file = Tempfile.new(['report', '.pdf'], binmode: true)
success = system(
_output, error, status = Open3.capture3(
'pdfunite', report_file.path, file.path, merged_file.path 'pdfunite', report_file.path, file.path, merged_file.path
) )
unless success && File.file?(merged_file) # don't raise error if the issue was an encrypted pdf, which pdfunite doesn't support
raise StandardError, 'There was an error merging report and PDF file preview' if error.include?(PDFUNITE_ENCRYPTED_PDF_ERROR_STRING)
Rails.logger.warn("Cannot merge encrypted PDF #{file.path}, skipping!")
file.close(true)
merged_file.close(true)
# return the report file unchanged, as no merge was done
return report_file
elsif !status.success? || !File.file?(merged_file)
raise StandardError, "There was an error merging report and PDF file preview (#{error})"
end end
file.close(true) file.close(true)