diff --git a/app/models/concerns/favoritable.rb b/app/models/concerns/favoritable.rb index 8140ab060..60a6b2ec4 100644 --- a/app/models/concerns/favoritable.rb +++ b/app/models/concerns/favoritable.rb @@ -8,7 +8,7 @@ module Favoritable scope :favorite_for, ->(user) { joins(:favorites).where(favorites: { user: user }) } scope :with_favorites, lambda { |user| - joins("LEFT JOIN favorites ON item_id = #{table_name}.id AND item_type = '#{name}' AND favorites.user_id = #{user.id}") + joins("LEFT JOIN favorites ON favorites.item_id = #{table_name}.id AND favorites.item_type = '#{name}' AND favorites.user_id = #{user.id}") .select("#{table_name}.*, favorites.id IS NOT NULL AS favorite") } end diff --git a/app/services/lists/my_modules_service.rb b/app/services/lists/my_modules_service.rb index e14101eb1..2e209fd21 100644 --- a/app/services/lists/my_modules_service.rb +++ b/app/services/lists/my_modules_service.rb @@ -17,7 +17,6 @@ module Lists def fetch_records @records = @raw_data.includes(PRELOAD) .with_favorites(@user) - .group('my_modules.id, favorites.id') view_mode = if @params[:experiment].archived_branch? 'archived'