Implement dynamic subject class handling in generalnotification [SCI-9825]

app/helpers/application_helper.rb

@@ -106,7 +106,9 @@ module ApplicationHelper
       {
         type: :smart_annotation_added,
         title: sanitize_input(title),
-        subject: subject,
+        subject_id: subject.id,
+        subject_class: subject.class.name,
+        subject_name: subject.respond_to?(:name) && subject.name,
         user: target_user
       }
     )

app/notifications/general_notification.rb

@@ -14,6 +14,9 @@ class GeneralNotification < BaseNotification
   end
 
   def subject
-    params[:subject]
+    subject_class = params[:subject_class].constantize
+    subject_class.find(params[:subject_id])
+  rescue NameError, ActiveRecord::RecordNotFound
+    NonExistantRecord.new(params[:subject_name])
   end
 end