Fixed experiment level permission checks in the controllers.

This commit is contained in:
Matej Zrimšek 2018-02-05 18:55:37 +01:00
parent 7938c2e036
commit 1182ce5da1
2 changed files with 3 additions and 5 deletions

View file

@ -218,9 +218,7 @@ class CanvasController < ApplicationController
end
def check_edit_canvas
unless can_edit_canvas(@experiment)
render_403 and return
end
render_403 and return unless can_manage_experiment?(@experiment)
end
def check_view_canvas

View file

@ -1122,8 +1122,8 @@ class ProtocolsController < ApplicationController
@my_module = @protocol.my_module
render_403 unless @my_module.present? &&
(can_read_protocol_in_module?(protocol) ||
can_create_protocols_in_repository?(protocol.team))
(can_read_protocol_in_module?(@protocol) ||
can_create_protocols_in_repository?(@protocol.team))
end
def check_make_private_permissions