Fix JS errors on text results creation/editing [SCI-9140] (#6086)

app/assets/javascripts/my_modules/results.js

@@ -148,7 +148,7 @@
             .removeClass(GLOBAL_CONSTANTS.HAS_UNSAVED_DATA_CLASS_NAME);
           break;
         case ResultTypeEnum.TEXT:
-          textWithoutImages = TinyMCE.getContent().replaceAll(/src="(data:image\/[^;]+;base64[^"]+)"/i, '');
+          textWithoutImages = TinyMCE.getContent().replaceAll(/src="(data:image\/[^;]+;base64[^"]+)"/g, '');
 
           textValidator(
             ev, $form.find('#result_text_attributes_textarea'), 1,

app/assets/javascripts/results/result_texts.js

@@ -40,6 +40,12 @@
       });
     }
 
+    function initSaveReslutText() {
+      $('#results').on('click', '.edit-text-result .save-result', (event) => {
+        Results.processResult(event, Results.ResultTypeEnum.TEXT);
+      });
+    }
+
     // Edit result text button behaviour
     function applyEditResultTextCallback() {
       $('.edit-result-text').off('ajax:success ajax:error').on('ajax:success', function(e, data) {
@@ -101,6 +107,7 @@
 
     publicAPI = Object.freeze({
       initNewReslutText: initNewReslutText,
+      initSaveReslutText: initSaveReslutText,
       applyEditResultTextCallback: applyEditResultTextCallback
     });
 
@@ -108,5 +115,6 @@
   }());
 
   ResultText.initNewReslutText();
+  ResultText.initSaveReslutText();
   ResultText.applyEditResultTextCallback();
 }());

app/assets/javascripts/results/result_texts/edit.js

@@ -1,7 +0,0 @@
-/* global Results */
-
-(function() {
-  $('.edit-result-texts-buttons').on('click', '.save-result', (event) => {
-    Results.processResult(event, Results.ResultTypeEnum.TEXT);
-  });
-}());

app/assets/javascripts/results/result_texts/new.js

@@ -1,7 +0,0 @@
-/* global Results */
-
-(function() {
-  $('.new-result-texts-buttons').on('click', '.save-result', (event) => {
-    Results.processResult(event, Results.ResultTypeEnum.TEXT);
-  });
-}());

app/assets/javascripts/sitewide/comments.js

@@ -87,8 +87,7 @@ var Comments = (function() {
           $el.find('.new-comment-button').removeClass('show');
           newButton.disable = false;
           $el.find('textarea').focus().blur();
-        })
+        }).fail((error) => {
-          .error((error) => {
           if (error.status === 403) {
             HelperModule.flashAlertMsg(I18n.t('general.no_permissions'), 'danger');
           }

app/views/result_texts/_edit.html.erb

@@ -21,7 +21,6 @@
       </button>
       <%= f.button t("general.save"),
                    class: 'btn btn-primary save-result' %>
-      <%= javascript_include_tag 'results/result_texts/edit' %>
     </div>
   <% end %>
 </div>

app/views/result_texts/_new.html.erb

@@ -20,7 +20,6 @@
       </button>
       <%= f.button t("result_texts.new.create"),
                    class: 'btn btn-primary save-result' %>
-      <%= javascript_include_tag 'results/result_texts/new' %>
     </div>
   <% end %>
 </div>

config/initializers/assets.rb

@@ -106,8 +106,6 @@ Rails.application.config.assets.precompile += %w(users/registrations/new_with_pr
 Rails.application.config.assets.precompile += %w(team_zip_exports/load_handson.js)
 Rails.application.config.assets.precompile += %w(repository_columns/manage_column_partials/number.js)
 Rails.application.config.assets.precompile += %w(repository_columns/manage_column_partials/stock.js)
-Rails.application.config.assets.precompile += %w(results/result_texts/new.js)
-Rails.application.config.assets.precompile += %w(results/result_texts/edit.js)
 Rails.application.config.assets.precompile += %w(shared/file_preview.js)
 Rails.application.config.assets.precompile += %w(users/shared/linkedin_sign_in_links.js)
 Rails.application.config.assets.precompile += %w(reports/template_helpers.js)