diff --git a/app/controllers/assets_controller.rb b/app/controllers/assets_controller.rb index 919495540..e7abe9e37 100644 --- a/app/controllers/assets_controller.rb +++ b/app/controllers/assets_controller.rb @@ -17,8 +17,8 @@ class AssetsController < ApplicationController helper_method :wopi_file_edit_button_status before_action :load_vars, except: :create_wopi_file - before_action :check_read_permission, except: %i(edit destroy create_wopi_file) - before_action :check_edit_permission, only: %i(edit destroy) + before_action :check_read_permission, except: %i(edit destroy create_wopi_file toggle_view_mode) + before_action :check_edit_permission, only: %i(edit destroy toggle_view_mode) def file_preview render json: { html: render_to_string( @@ -191,7 +191,7 @@ class AssetsController < ApplicationController def destroy if @asset.destroy - render json: { flash: I18n.t('assets.file_deleted', file_name: @asset.file_name ) } + render json: { flash: I18n.t('assets.file_deleted', file_name: @asset.file_name) } else render json: {}, status: :unprocessable_entity end diff --git a/app/controllers/steps_controller.rb b/app/controllers/steps_controller.rb index 7b71dd7fb..080946a91 100644 --- a/app/controllers/steps_controller.rb +++ b/app/controllers/steps_controller.rb @@ -9,8 +9,9 @@ class StepsController < ApplicationController before_action :load_vars_nested, only: %i(new create) before_action :convert_table_contents_to_utf8, only: %i(create update) - before_action :check_view_permissions, only: %i(show update_view_state update_asset_view_mode) - before_action :check_manage_permissions, only: %i(new create edit update destroy move_up move_down) + before_action :check_view_permissions, only: :show + before_action :check_manage_permissions, only: %i(new create edit update destroy move_up move_down + update_view_state update_asset_view_mode) before_action :check_complete_and_checkbox_permissions, only: %i(toggle_step_state checklistitem_state) def new diff --git a/app/views/assets/_asset_context_menu.html.erb b/app/views/assets/_asset_context_menu.html.erb index f7fef391a..6eaaedb27 100644 --- a/app/views/assets/_asset_context_menu.html.erb +++ b/app/views/assets/_asset_context_menu.html.erb @@ -1,70 +1,72 @@ - +<% end %> diff --git a/app/views/steps/attachments/_list.html.erb b/app/views/steps/attachments/_list.html.erb index 8b661d393..9be91414b 100644 --- a/app/views/steps/attachments/_list.html.erb +++ b/app/views/steps/attachments/_list.html.erb @@ -10,7 +10,8 @@ <%= t('protocols.steps.files', count: assets.length) %> - <% unless preview %> + <% if !(preview) && (can_manage_protocol_in_module?(@protocol) || + can_manage_protocol_in_repository?(@protocol)) %>