diff --git a/app/controllers/dashboard/calendars_controller.rb b/app/controllers/dashboard/calendars_controller.rb index cbac57e26..5f098cfdf 100644 --- a/app/controllers/dashboard/calendars_controller.rb +++ b/app/controllers/dashboard/calendars_controller.rb @@ -3,7 +3,7 @@ module Dashboard class CalendarsController < ApplicationController include IconsHelper - include MyModulesListPartialHelper + include MyModulesHelper def show date = DateTime.parse(params[:date]) @@ -27,10 +27,9 @@ module Dashboard .where(projects: { archived: false }) .where('DATE(my_modules.due_date) = DATE(?)', date) .where(projects: { team_id: current_team.id }) - my_modules_grouped = my_modules_list_partial(my_modules) render json: { html: render_to_string(partial: 'shared/my_modules_list_partial.html.erb', locals: { - task_groups: my_modules_grouped + my_modules: my_modules }) } end diff --git a/app/controllers/repository_rows_controller.rb b/app/controllers/repository_rows_controller.rb index 90fb66b39..79f9ad8c4 100644 --- a/app/controllers/repository_rows_controller.rb +++ b/app/controllers/repository_rows_controller.rb @@ -2,7 +2,7 @@ class RepositoryRowsController < ApplicationController include InputSanitizeHelper include ActionView::Helpers::TextHelper include ApplicationHelper - include MyModulesListPartialHelper + include MyModulesHelper before_action :load_info_modal_vars, only: %i(show assigned_task_list) before_action :load_vars, only: %i(edit update) @@ -184,10 +184,9 @@ class RepositoryRowsController < ApplicationController def assigned_task_list my_modules = @repository_row.my_modules.joins(experiment: :project) .search_by_name(current_user, current_team, params[:query]) - my_modules_grouped = my_modules_list_partial(my_modules) render json: { html: render_to_string(partial: 'shared/my_modules_list_partial.html.erb', locals: { - task_groups: my_modules_grouped + my_modules: my_modules }) } end diff --git a/app/helpers/my_modules_helper.rb b/app/helpers/my_modules_helper.rb index bb31c0e8a..9e6c1d420 100644 --- a/app/helpers/my_modules_helper.rb +++ b/app/helpers/my_modules_helper.rb @@ -55,4 +55,22 @@ module MyModulesHelper def is_results_page? action_name == 'results' end + + def grouped_by_prj_exp(my_modules) + ungrouped_tasks = my_modules.joins(experiment: :project) + .select('experiments.name as experiment_name, + experiments.archived as experiment_archived, + projects.name as project_name, + projects.archived as project_archived, + my_modules.*') + ungrouped_tasks.group_by { |i| [i[:project_name], i[:experiment_name]] }.map do |group, tasks| + { + project_name: group[0], + project_archived: tasks[0]&.project_archived, + experiment_name: group[1], + experiment_archived: tasks[0]&.experiment_archived, + tasks: tasks + } + end + end end diff --git a/app/helpers/my_modules_list_partial_helper.rb b/app/helpers/my_modules_list_partial_helper.rb deleted file mode 100644 index b35881a0c..000000000 --- a/app/helpers/my_modules_list_partial_helper.rb +++ /dev/null @@ -1,21 +0,0 @@ -# frozen_string_literal: true - -module MyModulesListPartialHelper - def my_modules_list_partial(my_modules) - ungrouped_tasks = my_modules.joins(experiment: :project) - .select('experiments.name as experiment_name, - experiments.archived as experiment_archived, - projects.name as project_name, - projects.archived as project_archived, - my_modules.*') - ungrouped_tasks.group_by { |i| [i[:project_name], i[:experiment_name]] }.map do |group, tasks| - { - project_name: group[0], - project_archived: tasks[0]&.project_archived, - experiment_name: group[1], - experiment_archived: tasks[0]&.experiment_archived, - tasks: tasks - } - end - end -end diff --git a/app/views/shared/_my_modules_list_partial.html.erb b/app/views/shared/_my_modules_list_partial.html.erb index 5edb1447c..d35776e66 100644 --- a/app/views/shared/_my_modules_list_partial.html.erb +++ b/app/views/shared/_my_modules_list_partial.html.erb @@ -1,5 +1,5 @@
- <% task_groups.each do |task_group| %> + <% grouped_by_prj_exp(my_modules).each do |task_group| %>
<% if task_group[:project_archived]%>