scinote-eln/scinote-web
1
1
Fork 0
mirror of https://github.com/scinote-eln/scinote-web.git synced 2024-11-10 17:36:33 +08:00
Code Issues Projects Releases Packages Wiki Activity

hound code cleanup

Browse source
This commit is contained in:
Giga Chubinidze 2022-12-20 10:37:40 +04:00
parent 1a84c60c74
commit 377872dda3
2 changed files with 10 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
app/assets/javascripts/experiments/show.js
View file

@ -27,9 +27,7 @@
// For submitting correct id values of the chosen tags
$.map(dropdownSelector.getValues(myModuleTagsSelector), function(val) {
if ($(`${myModuleTagsSelector} option[value=${val}]`).length === 0) {
$(myModuleTagsSelector).append(
$(`<option selected="true" value="${val}">${val}</option>`)
);
$(myModuleTagsSelector).append($(`<option selected="true" value="${val}">${val}</option>`));
} else {
$(`${myModuleTagsSelector} option[value=${val}]`).prop('selected', true);
}
@ -100,9 +98,6 @@
if (lastTagId > 0) {
newTag = { my_module_tag: { tag_id: lastTagId } };
(function() {
dropdownSelector.removeValue(myModuleTagsSelector, lastTagId, '', true);
});
} else {
newTag = {
tag: {
@ -113,32 +108,21 @@
my_module_id: selectElement.data('module-id'),
simple_creation: true
};
$.post(selectElement.data('tags-create-url'), newTag, function(result) {
$.post(selectElement.data('tags-create-url'), newTag, function(res) {
dropdownSelector.removeValue(myModuleTagsSelector, 0, '', true);
dropdownSelector.addValue(myModuleTagsSelector, {
value: result.tag.id,
label: result.tag.name,
value: res.tag.id,
label: res.tag.name,
params: {
color: result.tag.color
color: res.tag.color
}
}, true);
}).fail(function() {
dropdownSelector.removeValue(myModuleTagsSelector, lastTagId, '', true);
});
}
},
onUnSelect: (id) => {
$.post(`${$(myModuleTagsSelector).data('update-module-tags-url')}/${id}/destroy_by_tag_id`)
.success(function() {
dropdownSelector.closeDropdown(myModuleTagsSelector);
})
.fail(function(r) {
if (r.status === 403) {
HelperModule.flashAlertMsg(I18n.t('general.no_permissions'), 'danger');
}
});
}
})
});
});
}

9
app/controllers/projects_controller.rb
View file

@ -264,15 +264,14 @@ class ProjectsController < ApplicationController
end
end
def create_tag
render_403 unless can_manage_project_tags?(@project)
@tag = @project.tags.create(tag_params.merge({
created_by: current_user,
last_modified_by: current_user,
color: Constants::TAG_COLORS.sample
}))
created_by: current_user,
last_modified_by: current_user,
color: Constants::TAG_COLORS.sample
}))
render json: {
tag: {