From 378e91b426f1a7cfb24e84e682d46b0d6e987acc Mon Sep 17 00:00:00 2001 From: aignatov-bio <47317017+aignatov-bio@users.noreply.github.com> Date: Tue, 2 Jul 2019 11:21:00 +0200 Subject: [PATCH] Fix links on search page (#1867) --- app/assets/javascripts/protocols/steps.js.erb | 2 +- app/views/search/index.html.erb | 2 +- app/views/search/results/_comments.html.erb | 75 +++++++++++++++---- app/views/search/results/_protocols.html.erb | 11 +-- .../results/partials/_protocol_text.html.erb | 9 +++ 5 files changed, 71 insertions(+), 28 deletions(-) diff --git a/app/assets/javascripts/protocols/steps.js.erb b/app/assets/javascripts/protocols/steps.js.erb index 15007647c..bdff14201 100644 --- a/app/assets/javascripts/protocols/steps.js.erb +++ b/app/assets/javascripts/protocols/steps.js.erb @@ -378,7 +378,7 @@ } function initCallBacks() { - applyCreateWopiFileCallback(); + if (typeof(applyCreateWopiFileCallback) === 'function') applyCreateWopiFileCallback(); applyCheckboxCallBack(); applyStepCompletedCallBack(); applyEditCallBack(); diff --git a/app/views/search/index.html.erb b/app/views/search/index.html.erb index 85c4d0349..790b6c573 100644 --- a/app/views/search/index.html.erb +++ b/app/views/search/index.html.erb @@ -1,5 +1,5 @@ <% provide(:head_title, t("search.index.head_title")) %> - +<%= render partial: "protocols/index/protocol_preview_modal.html.erb" %>
<% if comment.is_a?(ProjectComment) && comment.project.present? %>
-
- <%=t "search.index.project" %>
- <%= render partial: "search/results/partials/project_text.html.erb",
- locals: { project: comment.project, link_to_page: :root } %>
-
+ <% project = comment.project %>
<% elsif comment.is_a?(TaskComment) && comment.my_module.present? %>
-
- <%=t "search.index.module" %>
- <%= render partial: "search/results/partials/my_module_text.html.erb",
- locals: { my_module: comment.my_module, link_to_page: :canvas } %>
-
+ <% my_module = comment.my_module %>
+ <% experiment = my_module.experiment %>
+ <% project = experiment.project %>
<% elsif comment.is_a?(StepComment) && comment.step.present? %>
-
- <%=t "search.index.step" %>
- <%= render partial: "search/results/partials/step_text.html.erb",
- locals: { step: comment.step, target: :comment } %>
-
+ <% step = comment.step %>
+ <% my_module = step.protocol.my_module %>
+ <% experiment = my_module.experiment %>
+ <% project = experiment.project %>
<% elsif comment.is_a?(ResultComment) && comment.result.present? %>
+ <% result = comment.result %>
+ <% my_module = result.my_module %>
+ <% experiment = my_module.experiment %>
+ <% project = experiment.project %>
+ <% end %>
+
+
+
+
+ <% if result %>
<%=t "search.index.result" %>
<%= render partial: "search/results/partials/result_text.html.erb",
- locals: { result: comment.result, target: :comment } %>
+ locals: { result: result, target: :comment } %>
+
<% end %>
+
+ <% if step %>
+
+ <%=t "search.index.step" %>
+ <%= render partial: "search/results/partials/step_text.html.erb",
+ locals: { step: step, target: :comment } %>
+
+
+ <% end %>
+
+ <% if my_module %>
+
+ <%=t "search.index.module" %>
+ <%= render partial: "search/results/partials/my_module_text.html.erb",
+ locals: { my_module: my_module, link_to_page: :canvas } %>
+
+
+ <% end %>
+
+ <% if experiment %>
+
+ <%=t "search.index.experiment" %>
+ <%= render partial: "search/results/partials/experiment_text.html.erb",
+ locals: { experiment: experiment } %>
+
+
+ <% end %>
+
+
+ <%=t "search.index.project" %>
+ <%= render partial: "search/results/partials/project_text.html.erb",
+ locals: { project: project, link_to_page: :show } %>
+
+
+
+ <%=t "search.index.team" %>
+ <%= render partial: "search/results/partials/team_text.html.erb",
+ locals: { team: project.team } %>
+