Merge pull request #1139 from okriuchykhin/ok_SCI_2385

Fix task resore permissions [SCI-2385]
This commit is contained in:
okriuchykhin 2018-05-16 10:17:51 +02:00 committed by GitHub
commit 3e2b455d2c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -144,12 +144,6 @@ class MyModulesController < ApplicationController
end
def update
render_403 && return unless if my_module_params[:archived] == 'false'
can_restore_module?(@my_module)
else
can_manage_module?(@my_module)
end
@my_module.assign_attributes(my_module_params)
@my_module.last_modified_by = current_user
description_changed = @my_module.description_changed?
@ -669,7 +663,11 @@ class MyModulesController < ApplicationController
end
def check_manage_permissions
render_403 unless can_manage_module?(@my_module)
render_403 && return unless if my_module_params[:archived] == 'false'
can_restore_module?(@my_module)
else
can_manage_module?(@my_module)
end
end
def check_view_permissions