mirror of
https://github.com/scinote-eln/scinote-web.git
synced 2025-09-30 08:54:31 +08:00
Enable protocol template renaming [SCI-10851]
This commit is contained in:
parent
ab2f5c16b4
commit
452547564e
3 changed files with 0 additions and 10 deletions
|
@ -909,7 +909,6 @@ class ProtocolsController < ApplicationController
|
|||
end
|
||||
|
||||
def set_inline_name_editing
|
||||
return unless @protocol.initial_draft?
|
||||
return unless can_manage_protocol_draft_in_repository?(@protocol)
|
||||
|
||||
@inline_editable_title_config = {
|
||||
|
|
|
@ -70,12 +70,10 @@ class Protocol < ApplicationRecord
|
|||
with_options if: :in_repository_published_version? do
|
||||
validates :parent, presence: true
|
||||
validate :parent_type_constraint
|
||||
validate :versions_same_name_constraint
|
||||
end
|
||||
with_options if: :in_repository_draft? do
|
||||
# Only one draft can exist for each protocol
|
||||
validate :ensure_single_draft
|
||||
validate :versions_same_name_constraint
|
||||
end
|
||||
with_options if: -> { in_repository? && !parent && !archived_changed?(from: false) } do |protocol|
|
||||
# Active protocol must have unique name inside its team
|
||||
|
@ -797,12 +795,6 @@ class Protocol < ApplicationRecord
|
|||
end
|
||||
end
|
||||
|
||||
def versions_same_name_constraint
|
||||
if parent.present? && !parent.name.eql?(name)
|
||||
errors.add(:base, I18n.t('activerecord.errors.models.protocol.wrong_version_name'))
|
||||
end
|
||||
end
|
||||
|
||||
def version_number_constraint
|
||||
if Protocol.where(protocol_type: Protocol::REPOSITORY_TYPES)
|
||||
.where.not(id: id)
|
||||
|
|
|
@ -166,7 +166,6 @@ en:
|
|||
protocol:
|
||||
unchangable: "Published protocols can not be changed!"
|
||||
wrong_parent_type: "Protocol can only be linked to published protocol!"
|
||||
wrong_version_name: "Protocol versions should have same name!"
|
||||
wrong_version_number: "Protocol version number should be sequential!"
|
||||
wrong_parent_draft_number: "Procol can have only 1 draft"
|
||||
attributes:
|
||||
|
|
Loading…
Add table
Reference in a new issue