From 50822ba8832e9d122ecc9fca16c30f626fafb55e Mon Sep 17 00:00:00 2001 From: Alex Kriuchykhin Date: Wed, 26 Feb 2025 09:40:18 +0100 Subject: [PATCH] Fix permission checks for protocols draft comment editing [SCI-11586] (#8264) --- app/serializers/protocol_draft_serializer.rb | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/app/serializers/protocol_draft_serializer.rb b/app/serializers/protocol_draft_serializer.rb index a1ff68af6..b77ddcf7a 100644 --- a/app/serializers/protocol_draft_serializer.rb +++ b/app/serializers/protocol_draft_serializer.rb @@ -29,14 +29,8 @@ class ProtocolDraftSerializer < ActiveModel::Serializer } urls_list[:publish] = publish_protocol_path(object) if can_publish_protocol_in_repository?(current_user, object) - if can_delete_protocol_draft_in_repository?(current_user, object) - urls_list[:destroy] = destroy_draft_protocol_path(object) - end - - if can_manage_protocol_draft_in_repository?(current_user, object) && - can_publish_protocol_in_repository?(current_user, object) - urls_list[:comment] = update_version_comment_protocol_path(object) - end + urls_list[:destroy] = destroy_draft_protocol_path(object) if can_delete_protocol_draft_in_repository?(current_user, object) + urls_list[:comment] = update_version_comment_protocol_path(object) if can_manage_protocol_draft_in_repository?(current_user, object) urls_list end