Merge pull request #5378 from artoscinote/ma_SCI_8324

Fix main navigation issues [SCI-8324]

app/assets/stylesheets/navigation/top_menu.scss

@@ -38,6 +38,14 @@
     margin-left: auto;
     margin-right: 1em;
     width: 240px;
+
+    input {
+      border-color: $color-alto;
+    }
+
+    .fas {
+      color: $color-silver-chalice;
+    }
   }
 
   .sci--navigation--top-menu-user {

app/assets/stylesheets/shared/comments_sidebar.scss

@@ -9,7 +9,7 @@
   top: var(--top-navigation-height);
   transition: width .3s;
   width: 0;
-  z-index: 10000;
+  z-index: 609;
 
   &.open {
     width: var(--comments-sidebar-width);

app/javascript/vue/navigation/top_menu.vue

@@ -25,8 +25,8 @@
         <i class="fas fa-question-circle"></i>
       </button>
       <ul v-if="user" class="dropdown-menu dropdown-menu-right">
-        <li v-for="(item, i) in helpMenu">
-          <a :key="i" :href="item.url">
+        <li v-for="(item, i) in helpMenu" :key="i">
+          <a :href="item.url" target="_blank">
             {{ item.name }}
           </a>
         </li>
@@ -37,8 +37,8 @@
         <i class="fas fa-cog"></i>
       </button>
       <ul class="dropdown-menu dropdown-menu-right">
-        <li v-for="(item, i) in settingsMenu">
-          <a :key="i" :href="item.url">
+        <li v-for="(item, i) in settingsMenu" :key="i">
+          <a :href="item.url">
             {{ item.name }}
           </a>
         </li>
@@ -71,8 +71,8 @@
         <img class="avatar" :src="user.avatar_url">
       </div>
       <div class="dropdown-menu dropdown-menu-right">
-        <li v-for="(item, i) in userMenu">
-          <a :key="i" :href="item.url">
+        <li v-for="(item, i) in userMenu" :key="i">
+          <a :href="item.url">
             {{ item.name }}
           </a>
         </li>

config/locales/en.yml

@@ -262,7 +262,7 @@ en:
     notifications:
       title: "Notifications"
       all: "All"
-      message: "Message"
+      message: "Messages"
       system: "System"
       today: "Today"
       older: "Older"
@@ -2412,7 +2412,7 @@ en:
           profile: "My profile"
           preferences: "My preferences"
           addons: "Add-ons"
-          connected_accounts: "Connected Accounts"
+          connected_accounts: "Connected accounts"
       account:
         preferences:
           head_title: "Settings | My preferences"