Fix API and tests for new task completion logic [SCI-5004]

This commit is contained in:
Oleksii Kriuchykhin 2020-09-15 11:19:25 +02:00
parent 73cf620960
commit 57716fd89c
2 changed files with 5 additions and 18 deletions

View file

@ -60,13 +60,13 @@ module Api
def task_params_create def task_params_create
raise TypeError unless params.require(:data).require(:type) == 'tasks' raise TypeError unless params.require(:data).require(:type) == 'tasks'
params.require(:data).require(:attributes).permit(%i(name x y description state)) params.require(:data).require(:attributes).permit(%i(name x y description))
end end
def task_params_update def task_params_update
raise TypeError unless params.require(:data).require(:type) == 'tasks' raise TypeError unless params.require(:data).require(:type) == 'tasks'
params.require(:data).require(:attributes).permit(%i(name x y description state my_module_status_id)) params.require(:data).require(:attributes).permit(%i(name x y description my_module_status_id))
end end
def load_task_for_managing def load_task_for_managing

View file

@ -292,7 +292,7 @@ RSpec.describe 'Api::V1::TasksController', type: :request do
end end
end end
context 'task completion, when has valid params' do context 'direct task completion disabled, when has valid params' do
let(:request_body) do let(:request_body) do
{ {
data: { data: {
@ -304,23 +304,10 @@ RSpec.describe 'Api::V1::TasksController', type: :request do
} }
end end
it 'returns status 200' do it 'returns status 204, no changes to task' do
action action
expect(response).to have_http_status 200 expect(response).to have_http_status 204
end
it 'returns well formated response' do
action
expect(json).to match(
hash_including(
data: hash_including(
type: 'tasks',
attributes: hash_including(state: 'completed')
)
)
)
end end
end end